Fix 'Syntax node is not within syntax tree' exception in SharpSixRewriter#268
Fix 'Syntax node is not within syntax tree' exception in SharpSixRewriter#268theolivenbaum wants to merge 1 commit intomasterfrom
Conversation
…pSixRewriter Added a check to ensure `targetExpression` belongs to the same syntax tree as `semanticModel` before calling `GetTypeInfo` in `SharpSixRewriter.VisitInvocationExpression`. This prevents a crash when processing detached or synthetic nodes during rewriting of generic reduced extension methods. Co-authored-by: theolivenbaum <8791811+theolivenbaum@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR fixes a
System.ArgumentException: 'Syntax node is not within syntax tree'that occurs inSharpSixRewriterduring the rewriting process.The issue arises when
semanticModel.GetTypeInfo(targetExpression)is called on a node that is not part of the currentsemanticModel's syntax tree. This can happen if the node is synthesized or detached from the tree during previous rewriting steps.The fix adds an explicit check
targetExpression.SyntaxTree == semanticModel.SyntaxTreebefore attempting to retrieve type information. If the check fails, the optimization involving generic name generation is safely skipped.Verified by running
H5.Compiler.IntegrationTests(specificallyExtensionMethodsandGenericMethod_Basic).PR created automatically by Jules for task 12678319086030163130 started by @theolivenbaum