Add progress reporting to Qwen3 model download#8
Conversation
Modified `SentenceEncoder.CreateAsync` and `SentenceEncoder.DownloadModelAsync` to accept an `IProgress<float>` parameter for reporting download progress. Implemented logic to calculate progress based on content length and bytes read, handling retry scenarios correctly. Co-authored-by: theolivenbaum <8791811+theolivenbaum@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Added
IProgress<float>parameter toCreateAsyncandDownloadModelAsyncinSentenceTransformers.Qwen3to enable progress tracking during model download.Updated the download logic to calculate and report progress based on the total file size.
Verified the changes with a test script and ensured no regressions with existing tests.
PR created automatically by Jules for task 11762793748334050463 started by @theolivenbaum