Webhooks tools and tests#38
Merged
twk3 merged 4 commits intocursor/openapi-mcp-parity-9b9cfrom Jan 23, 2026
Merged
Conversation
…tools Co-authored-by: dj <dj@currents.dev>
- Add tests for listWebhooksTool (success and error cases) - Add tests for getWebhookTool (success and error cases) - Add tests for createWebhookTool (required fields, all fields, error cases) - Add tests for updateWebhookTool (single field, all fields, error cases) - Add tests for deleteWebhookTool (success and error cases) - All tests verify schema structure Co-authored-by: dj <dj@currents.dev>
These files referenced changes that have been reverted. The PR is now focused solely on webhook tools implementation. Co-authored-by: dj <dj@currents.dev>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: dj <dj@currents.dev>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
miguelangaranocurrents
added a commit
that referenced
this pull request
Jan 26, 2026
* feat: add webhook tools and fix parameter requirements for OpenAPI parity - Add 5 missing webhook MCP tools (list, create, get, update, delete) - Implement all webhook endpoints from OpenAPI spec - Fix date_start and date_end to be required parameters (per OpenAPI spec) in: - get-test-results.ts - get-spec-files-performance.ts - get-tests-performance.ts - Register webhook tools in index.ts with comprehensive descriptions - All webhook tools support full CRUD operations per OpenAPI specification Co-authored-by: miguel <miguel@currents.dev> * docs: add comprehensive PR summary and analysis Co-authored-by: miguel <miguel@currents.dev> * docs: add final implementation completion report Co-authored-by: miguel <miguel@currents.dev> * Webhooks tools and tests (#38) * revert: restore custom date defaults for performance and test result tools Co-authored-by: dj <dj@currents.dev> * test: add comprehensive tests for webhook tools - Add tests for listWebhooksTool (success and error cases) - Add tests for getWebhookTool (success and error cases) - Add tests for createWebhookTool (required fields, all fields, error cases) - Add tests for updateWebhookTool (single field, all fields, error cases) - Add tests for deleteWebhookTool (success and error cases) - All tests verify schema structure Co-authored-by: dj <dj@currents.dev> * chore: remove outdated documentation files These files referenced changes that have been reverted. The PR is now focused solely on webhook tools implementation. Co-authored-by: dj <dj@currents.dev> * docs: add webhook tools to README Co-authored-by: dj <dj@currents.dev> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> * fix: remove .default([]) from hookEvents to allow proper undefined check Removes .default([]) from hookEvents parameter in create-webhook.ts. This ensures that when hookEvents is not provided, it remains undefined rather than being set to an empty array, allowing the undefined check in the handler to work correctly and avoid sending empty arrays to the API. Addresses feedback from cubic code review. Co-authored-by: miguel <miguel@currents.dev> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: DJ Mountney <david.mountney@twkie.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert unintended date parameter changes and add comprehensive tests for the new webhook tools.
The
date_startanddate_endparameters inget-spec-files-performance.ts,get-test-results.ts, andget-tests-performance.tswere previously made required and their custom default values were removed. This PR restores their optional status and original default logic. Additionally, comprehensive tests have been added for all webhook tools to ensure their correct functionality, as requested. Outdated documentation files related to the previous broader scope of changes have also been removed for clarity.Summary by cubic
Restored optional date range parameters with sensible defaults in performance and test result tools, and added comprehensive tests for webhook tools. This fixes unintended changes and improves reliability.
Bug Fixes
Refactors
Written for commit 3f303fb. Summary will update on new commits.