Assert creation of scope handlers #2684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
approved these changes
Nov 30, 2024
Member
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
looks good subject to minor comments
| } | ||
|
|
||
| create( | ||
| tryCreate( |
Member
There was a problem hiding this comment.
I believe we usually use maybe for things like this, eg maybeCreate
| } | ||
| } | ||
|
|
||
| create( |
Member
There was a problem hiding this comment.
I would be tempted to call this createStrict or createOrThrow. Once we've migrated all scopes, this will never throw, right? So maybe we just leave it 🤷♂️
Member
Author
There was a problem hiding this comment.
Yes this shouldn't really throw. It's just there because I don't like doing ! assertion in typescript if we can get around it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist