Validate action description in factories

[AndreasArvidsson]

Since we don't have input validation we get these kind of errors to frequently:
#2685

Checklist

• [/] I have added tests
• [/] I have updated the docs and cheatsheet
• [/] I have not broken the cheatsheet

[pokey]

I think validation should be done during the validation stage in

cursorless/packages/common/src/util/ensureCommandShape.ts

Line 12 in 8cd7c21

export function ensureCommandShape(args: unknown[]): Command {

, rather than sprinkled all over our codebase. Is there a reason we can't do the validation there? I'm guessing it's simpler to it in these places where we've already drilled into the payload, but I still think it pollutes the code base and we'd have to remove it once we do proper schema validation

[AndreasArvidsson]

I rather not add an additional place where we need to drill down and create comprehensive switch cases for every single action, modifier, and scope. This was a very easy solution for a bad ux. Doing it properly would of course include schema validation.
It's only in three places. I could leave a link to the schema issue or link to the places where we have done this from the issue?

#983

[pokey]

update from meet-up: add // FIXME: remove once we have schema validation (#983) to each of these

[AndreasArvidsson]

fix me comments added