Skip to content

Default value for preferred scope setting #2687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Default value for preferred scope setting #2687

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e36caf
Default value for preferred scope setting
AndreasArvidsson Nov 20, 2024
a20d77b
Add the type arg name
AndreasArvidsson Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cursorless-talon/src/modifiers/simple_scope_modifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
# This is a private setting and should not be used by non Cursorless developers
mod.setting(
"private_cursorless_use_preferred_scope",
bool,
type=bool,
default=False,
desc="Use preferred scope instead of containing scope for all scopes by default (EXPERIMENTAL)",
)

Expand All @@ -42,7 +43,7 @@ def cursorless_simple_scope_modifier(m) -> dict[str, Any]:
"ancestorIndex": 1,
}

if settings.get("user.private_cursorless_use_preferred_scope", False):
if settings.get("user.private_cursorless_use_preferred_scope"):
return {
"type": "preferredScope",
"scopeType": m.cursorless_scope_type,
Expand Down
Loading