Proper handling of surrounding pair delimiter prefixes #2705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
reviewed
Jan 7, 2025
...gine/src/processTargets/modifiers/scopeHandlers/SurroundingPairScopeHandler/delimiterMaps.ts
Outdated
Show resolved
Hide resolved
.../src/processTargets/modifiers/scopeHandlers/SurroundingPairScopeHandler/getDelimiterRegex.ts
Outdated
Show resolved
Hide resolved
.../src/processTargets/modifiers/scopeHandlers/SurroundingPairScopeHandler/getDelimiterRegex.ts
Outdated
Show resolved
Hide resolved
…andlers/SurroundingPairScopeHandler/delimiterMaps.ts Co-authored-by: Pokey Rule <[email protected]>
AndreasArvidsson
commented
Jan 8, 2025
data/fixtures/recorded/surroundingPair/parseTree/typescript/changePair.yml
Outdated
Show resolved
Hide resolved
AndreasArvidsson
commented
Jan 8, 2025
phillco
reviewed
Jan 10, 2025
...gine/src/processTargets/modifiers/scopeHandlers/SurroundingPairScopeHandler/delimiterMaps.ts
Show resolved
Hide resolved
phillco
reviewed
Jan 10, 2025
phillco
approved these changes
Jan 10, 2025
cursorless-bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
On main `"take inside"` on `"command server"` will only select `command serve` because `r"` is considered a delimiter. This pull request fixes this. ## Checklist - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [/] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [/] I have not broken the cheatsheet --------- Co-authored-by: Pokey Rule <[email protected]> Co-authored-by: Phil Cohen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On main
"take inside"on"command server"will only selectcommand servebecauser"is considered a delimiter. This pull request fixes this.Checklist