Add action to select new targets #2707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasArvidsson
commented
Jan 4, 2025
pokey
reviewed
Jan 7, 2025
|
couldn't we solve this using #2157? |
|
Sounds like #2157 was discussed but this was considered to be a more elegant syntax (I agree) |
phillco
reviewed
Jan 9, 2025
phillco
reviewed
Jan 9, 2025
phillco
approved these changes
Jan 9, 2025
|
Going to merge, @pokey let us know if you have followup comments |
cursorless-bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
Adds a new selection while preserving existing ones `"append <target>"` replaces `"take this and <target>"` You can also use `append pre` and `append post` to add a cursor before or after the given target (rather than selecting that target), while keeping your current selections unchanged. (Previously you could do something like `pre this and <target>` but this would also reduce your current selection to a cursor before the current target.) ## Checklist - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet --------- Co-authored-by: Phil Cohen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new selection while preserving existing ones
"append <target>"replaces"take this and <target>"You can also use
append preandappend postto add a cursor before or after the given target (rather than selecting that target), while keeping your current selections unchanged. (Previously you could do something likepre this and <target>but this would also reduce your current selection to a cursor before the current target.)Checklist