Skip to content

Properly handle exception from missing vscode config json file #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Properly handle exception from missing vscode config json file #2728

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b9d917
Properly handle exception from missing vscode config json file
AndreasArvidsson Jan 14, 2025
fd9bea0
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] Jan 14, 2025
81d5a5b
Clean up
AndreasArvidsson Jan 14, 2025
0bad81a
Merge branch 'missingVscodeJson' of github.com:cursorless-dev/cursorl…
AndreasArvidsson Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cursorless-talon/src/apps/vscode_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ def vscode_get_setting_with_fallback(
return actions.user.vscode_get_setting(key, default_value), False
except Exception:
print(fallback_message)
traceback.print_exc()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just created a lot of noise in the Talon log. We know were the problem is without this.

return fallback_value, True


Expand Down
6 changes: 5 additions & 1 deletion cursorless-talon/src/marks/decorated_mark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,11 @@ def setup_hat_styles_csv(hat_colors: dict[str, str], hat_shapes: dict[str, str])
def init_hats(hat_colors: dict[str, str], hat_shapes: dict[str, str]):
setup_hat_styles_csv(hat_colors, hat_shapes)

vscode_settings_path: Path = actions.user.vscode_settings_path().resolve()
try:
vscode_settings_path: Path = actions.user.vscode_settings_path().resolve()
except Exception as ex:
print(ex)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the exception that was uncaught and broke Cursorless logic further up the call stack.

return lambda: None

def on_watch(path, flags):
global fast_reload_job, slow_reload_job
Expand Down
Loading