Skip to content

Re-enable scroll tests #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Re-enable scroll tests #2762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/cursorless-vscode-e2e/src/suite/revealRange.vscode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ async function preFile() {
});

assert.equal(editor.visibleRanges.length, 1);
// FIXME: Disabled to work around CI failure; see #2243
// assert.equal(editor.visibleRanges[0].start.line, 0);
assert.equal(editor.visibleRanges[0].start.line, 0);
}

async function postFile() {
Expand All @@ -61,6 +60,5 @@ async function postFile() {
});

assert.equal(editor.visibleRanges.length, 1);
// FIXME: Disabled to work around CI failure; see #2243
// assert.equal(editor.visibleRanges[0].end.line, editor.document.lineCount - 1);
assert.equal(editor.visibleRanges[0].end.line, editor.document.lineCount - 1);
}
14 changes: 6 additions & 8 deletions packages/cursorless-vscode-e2e/src/suite/scroll.vscode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { openNewEditor } from "@cursorless/vscode-common";
import * as vscode from "vscode";
import { endToEndTestSetup } from "../endToEndTestSetup";
import { runCursorlessCommand } from "@cursorless/vscode-common";
import assert from "node:assert";

suite("scroll", async function () {
endToEndTestSetup(this);
Expand All @@ -27,9 +28,8 @@ async function topWhale() {
],
});

// FIXME: Disabled to work around CI failure; see #2243
// assert.equal(editor.visibleRanges.length, 1);
// assert.equal(editor.visibleRanges[0].start.line, 1);
assert.equal(editor.visibleRanges.length, 1);
assert.equal(editor.visibleRanges[0].start.line, 1);
}

async function bottomWhale() {
Expand All @@ -40,8 +40,7 @@ async function bottomWhale() {
});
editor.selections = [new vscode.Selection(1, 0, 1, 0)];

// FIXME: Disabled to work around CI failure; see #2243
// assert.equal(editor.visibleRanges[0].start.line, 1);
assert.equal(editor.visibleRanges[0].start.line, 1);

await runCursorlessCommand({
version: 1,
Expand All @@ -56,7 +55,6 @@ async function bottomWhale() {
],
});

// FIXME: Disabled to work around CI failure; see #2243
// assert.equal(editor.visibleRanges.length, 1);
// assert.equal(editor.visibleRanges[0].start.line, 0);
assert.equal(editor.visibleRanges.length, 1);
assert.equal(editor.visibleRanges[0].start.line, 0);
}
Loading