Properly handle trailing commas in python arguments #2780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillco
reviewed
Jan 28, 2025
packages/cursorless-engine/src/processTargets/modifiers/scopeHandlers/BoundedScopeHandler.ts
Outdated
Show resolved
Hide resolved
packages/cursorless-engine/src/processTargets/modifiers/scopeHandlers/util/isHintsEveryScope.ts
Outdated
Show resolved
Hide resolved
phillco
reviewed
Jan 28, 2025
| /** | ||
| * Returns true if the hints belong to the every scope modifier. | ||
| */ | ||
| export function isHintsEveryScope(hints: ScopeIteratorRequirements): boolean { |
There was a problem hiding this comment.
Suggested change
| export function isHintsEveryScope(hints: ScopeIteratorRequirements): boolean { | |
| export function isEveryScope(hints: ScopeIteratorRequirements): boolean { |
phillco
reviewed
Jan 28, 2025
packages/cursorless-engine/src/processTargets/modifiers/scopeHandlers/util/isHintsEveryScope.ts
Outdated
Show resolved
Hide resolved
Comment on lines
5
to
14
| export function getCollectionItemRemovalRange( | ||
| isEveryScope: boolean, | ||
| editor: TextEditor, | ||
| contentRange: Range, | ||
| leadingDelimiterRange: Range | undefined, | ||
| trailingDelimiterRange: Range | undefined, | ||
| ): Range | undefined { | ||
| // We have both leading and trailing delimiter ranges | ||
| // If the leading one is longer/more specific, prefer to use that for removal; | ||
| // otherwise use undefined to fallback to the default behavior (often trailing) |
There was a problem hiding this comment.
Can we make this a docstring comment instead?
…andlers/util/isHintsEveryScope.ts
…andlers/BoundedScopeHandler.ts
phillco
reviewed
Jan 28, 2025
packages/cursorless-engine/src/processTargets/modifiers/scopeHandlers/BoundedScopeHandler.ts
Outdated
Show resolved
Hide resolved
…andlers/BoundedScopeHandler.ts
…s into pythonArguments
phillco
reviewed
Jan 28, 2025
...less-engine/src/processTargets/modifiers/scopeHandlers/util/getCollectionItemRemovalRange.ts
Outdated
Show resolved
Hide resolved
…andlers/util/getCollectionItemRemovalRange.ts
…s into pythonArguments
phillco
reviewed
Jan 28, 2025
...less-engine/src/processTargets/modifiers/scopeHandlers/util/getCollectionItemRemovalRange.ts
Show resolved
Hide resolved
phillco
reviewed
Jan 28, 2025
...less-engine/src/processTargets/modifiers/scopeHandlers/util/getCollectionItemRemovalRange.ts
Outdated
Show resolved
Hide resolved
phillco
reviewed
Jan 28, 2025
...less-engine/src/processTargets/modifiers/scopeHandlers/util/getCollectionItemRemovalRange.ts
Show resolved
Hide resolved
…andlers/util/getCollectionItemRemovalRange.ts
…andlers/util/getCollectionItemRemovalRange.ts
…andlers/util/getCollectionItemRemovalRange.ts
phillco
reviewed
Jan 28, 2025
...less-engine/src/processTargets/modifiers/scopeHandlers/util/getCollectionItemRemovalRange.ts
Outdated
Show resolved
Hide resolved
…andlers/util/getCollectionItemRemovalRange.ts
phillco
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #807
Checklist