Changed getRemovalHighlightRange to return a GeneralizedRange #2784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sourceStyle: FlashStyle; | ||
| destinationStyle: FlashStyle; | ||
| getSourceRangeCallback: (target: Target) => Range; | ||
| getSourceRangeCallback?: (target: Target) => GeneralizedRange; |
There was a problem hiding this comment.
Made this optional. If you don't pass a callback into flashTargets() the content range is used by default.
| decoration = { | ||
| sourceStyle: FlashStyle.referenced, | ||
| destinationStyle: FlashStyle.pendingModification0, | ||
| getSourceRangeCallback: getContentRange, |
There was a problem hiding this comment.
Just use default content range implementation
| ide(), | ||
| targets, | ||
| FlashStyle.referenced, | ||
| (target) => target.contentRange, |
There was a problem hiding this comment.
Use default content range implementation
| .map((target) => { | ||
| const range = getRange(target); | ||
|
|
||
| if (range == null) { |
There was a problem hiding this comment.
This optional behavior was never used. Better to have simpler code.
phillco
reviewed
Jan 28, 2025
phillco
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1657
Checklist