Migrate snippets follow up #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

phillco merged 6 commits into main from migrateSnippetsV2

Jan 30, 2025

Member

AndreasArvidsson commented Jan 29, 2025 •

edited

Loading

Skip snippets with fields we cannot migrate instead of just discarding those fields
Show a untitled markdown document with the migration results
Use spoken forms/phrases from Talon

Checklist

[/] I have added tests
[/] I have updated the docs and cheatsheet
[/] I have not broken the cheatsheet

AndreasArvidsson added 2 commits

January 29, 2025 07:51


          Open markdown result page after snippet migration

f6f4dab


          Use spoken forms in migration

f738b64

AndreasArvidsson requested a review from a team as a code owner

January 29, 2025 08:00

AndreasArvidsson mentioned this pull request

Added voice command to migrate Cursorless snippet to community format #2747

Merged

2 tasks


          rename

0d0981b

phillco reviewed

View reviewed changes

packages/cursorless-vscode/src/migrateSnippets.ts Outdated Show resolved Hide resolved

phillco reviewed

View reviewed changes

packages/cursorless-vscode/src/migrateSnippets.ts Outdated Show resolved Hide resolved

phillco reviewed

View reviewed changes

packages/cursorless-vscode/src/migrateSnippets.ts Outdated Show resolved Hide resolved


          Apply suggestions from code review

07fedc4

phillco reviewed

View reviewed changes

packages/cursorless-vscode/src/migrateSnippets.ts Show resolved Hide resolved

phillco reviewed

View reviewed changes

packages/cursorless-vscode/src/migrateSnippets.ts Outdated Show resolved Hide resolved

phillco reviewed

View reviewed changes

packages/cursorless-vscode/src/migrateSnippets.ts Show resolved Hide resolved


          Apply suggestions from code review

a98b37b

phillco approved these changes

View reviewed changes

phillco enabled auto-merge

January 30, 2025 16:52


          Merge branch 'main' into migrateSnippetsV2

78cbc27

phillco added this pull request to the merge queue

Merged via the queue into main with commit 2c19566

15 checks passed

phillco deleted the migrateSnippetsV2 branch

January 30, 2025 17:57

cursorless-bot pushed a commit that referenced this pull request


          Migrate snippets follow up (#2789)

1d7c9bd

1. Skip snippets with fields we cannot migrate instead of just
discarding those fields
2. Show a untitled markdown document with the migration results
3. Use spoken forms/phrases from Talon

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [/] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [/] I have not broken the cheatsheet

---------

Co-authored-by: Phil Cohen <[email protected]>

phillco mentioned this pull request

Deprecate Cursorless snippet format in favour of community snippets #2353

Closed

11 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet