Skip to content

Support legacy snippets #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 8, 2025
Merged

Support legacy snippets #2837

merged 6 commits into from
Feb 8, 2025

Conversation

AndreasArvidsson
Copy link
Member

Still support Cursorless (legacy) snippets extension side

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner February 7, 2025 04:12
pokey
pokey approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Painful to see this code come back, but unfortunately I think it's necessary. Presumably the VscodeSnippets.ts file was just around to perform migration, and will disappear entirely in the future?

@pokey pokey added this pull request to the merge queue Feb 8, 2025
Merged via the queue into main with commit be953a5 Feb 8, 2025
16 checks passed
@pokey pokey deleted the legacySnippets branch February 8, 2025 19:26
@AndreasArvidsson
Copy link
Member Author

AndreasArvidsson commented Feb 8, 2025 •
edited
Loading

Painful to see this code come back, but unfortunately I think it's necessary. Presumably the VscodeSnippets.ts file was just around to perform migration, and will disappear entirely in the future?

Used for the migration, but also openNewSnippetFile is used for the generate snippet action. That is a single function so I'm tempted to migrate it to the ide surface once the legacy snippet support is removed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pokey pokey pokey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndreasArvidsson @pokey