Remove snippets from spoken form json #2842
Conversation
| ) | ||
|
|
||
| fs.watch(str(file_path.parent), on_watch) | ||
| fs.watch(file_path.parent, on_watch) |
There was a problem hiding this comment.
Type change in Talon. You can pass either a path instance or a string and both will work, but only a path object does not give type errors.
| "-from": "experimental.setInstanceReference" | ||
| } | ||
| }, | ||
| "experimental/wrapper_snippets.csv": { |
There was a problem hiding this comment.
I wonder if we want to be more explicit. Just allowing us to leave out things feels like it's making it easier to make mistakes. Maybe we use a string "DEPRECATED"?
There was a problem hiding this comment.
I'm not sure what keeping the deprecated spoken forms in the json file helps with?
We still need to specify the file name otherwise we don't know which csv file to read if it exists. So we will never be matching anything against this files if we remove the path in the key. Or did you mean that "DEPRECATED" should be the value? I could also add an extra argument to init_csv_and_watch_changes instead of passing none as the default values?
Another option is to just set null as the value in the json file. Then we don't need to match against a particular string value.
A boolean argument to init_csv_and_watch_changes is probably my favorite solution of these.
There was a problem hiding this comment.
I went ahead with a boolean solution
Read from deprecated snippet csv files if the exists, but do not create them if they don't. Fixes #2841
2 participants
Read from deprecated snippet csv files if the exists, but do not create them if they don't.
Fixes #2841