Skip to content

Add missing markdown scope facets #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Add missing markdown scope facets #2848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
931a723
Added markdown facets
AndreasArvidsson Feb 12, 2025
b7e29e8
Added scope
AndreasArvidsson Feb 12, 2025
4bd1df3
Update test
AndreasArvidsson Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions data/fixtures/scopes/markdown/list.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
* hello
* stuff
---

[Content] =
[Removal] =
[Domain] = 0:0-1:7
>-------
0| * hello
1| * stuff
-------<

[Insertion delimiter] = " "
160 changes: 159 additions & 1 deletion packages/common/src/scopeSupportFacets/markdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import type { LanguageScopeSupportFacetMap } from "./scopeSupportFacets.types";
import { ScopeSupportFacetLevel } from "./scopeSupportFacets.types";

// eslint-disable-next-line @typescript-eslint/no-unused-vars
const { supported, unsupported, notApplicable } = ScopeSupportFacetLevel;

export const markdownScopeSupport: LanguageScopeSupportFacetMap = {
Expand All @@ -14,5 +13,164 @@ export const markdownScopeSupport: LanguageScopeSupportFacetMap = {

notebookCell: supported,
"interior.cell": supported,

"collectionItem.unenclosed": supported,
list: supported,

// Unsupported
"textFragment.comment.line": unsupported,
"textFragment.comment.block": unsupported,

// Not applicable

anonymousFunction: notApplicable,
"argument.actual": notApplicable,
"argument.actual.constructor": notApplicable,
"argument.actual.constructor.iteration": notApplicable,
"argument.actual.iteration": notApplicable,
"argument.actual.method": notApplicable,
"argument.actual.method.iteration": notApplicable,
"argument.formal": notApplicable,
"argument.formal.constructor": notApplicable,
"argument.formal.constructor.iteration": notApplicable,
"argument.formal.iteration": notApplicable,
"argument.formal.method": notApplicable,
"argument.formal.method.iteration": notApplicable,
attribute: notApplicable,
"branch.if": notApplicable,
"branch.if.iteration": notApplicable,
"branch.loop": notApplicable,
"branch.switchCase": notApplicable,
"branch.switchCase.iteration": notApplicable,
"branch.ternary": notApplicable,
"branch.try": notApplicable,
"branch.try.iteration": notApplicable,
class: notApplicable,
"class.iteration.block": notApplicable,
"class.iteration.document": notApplicable,
className: notApplicable,
"className.iteration.block": notApplicable,
"className.iteration.document": notApplicable,
"collectionItem.unenclosed.iteration": notApplicable,
command: notApplicable,
"condition.doWhile": notApplicable,
"condition.for": notApplicable,
"condition.if": notApplicable,
"condition.switchCase": notApplicable,
"condition.switchCase.iteration": notApplicable,
"condition.ternary": notApplicable,
"condition.while": notApplicable,
disqualifyDelimiter: notApplicable,
element: notApplicable,
endTag: notApplicable,
environment: notApplicable,
fieldAccess: notApplicable,
functionCall: notApplicable,
"functionCall.constructor": notApplicable,
functionCallee: notApplicable,
"functionCallee.constructor": notApplicable,
functionName: notApplicable,
"functionName.constructor": notApplicable,
"functionName.iteration.block": notApplicable,
"functionName.iteration.document": notApplicable,
"functionName.method": notApplicable,
"functionName.method.iteration.class": notApplicable,
ifStatement: notApplicable,
"interior.class": notApplicable,
"interior.command": notApplicable,
"interior.element": notApplicable,
"interior.function": notApplicable,
"interior.if": notApplicable,
"interior.lambda": notApplicable,
"interior.loop": notApplicable,
"interior.resource": notApplicable,
"interior.switchCase": notApplicable,
"interior.ternary": notApplicable,
"interior.try": notApplicable,
"key.attribute": notApplicable,
"key.mapPair": notApplicable,
"key.mapPair.iteration": notApplicable,
map: notApplicable,
"name.argument.actual": notApplicable,
"name.argument.actual.iteration": notApplicable,
"name.argument.formal": notApplicable,
"name.argument.formal.constructor": notApplicable,
"name.argument.formal.constructor.iteration": notApplicable,
"name.argument.formal.iteration": notApplicable,
"name.argument.formal.method": notApplicable,
"name.argument.formal.method.iteration": notApplicable,
"name.assignment": notApplicable,
"name.assignment.pattern": notApplicable,
"name.class": notApplicable,
"name.constructor": notApplicable,
"name.field": notApplicable,
"name.foreach": notApplicable,
"name.function": notApplicable,
"name.iteration.block": notApplicable,
"name.iteration.document": notApplicable,
"name.method": notApplicable,
"name.resource": notApplicable,
"name.resource.iteration": notApplicable,
"name.variable": notApplicable,
"name.variable.pattern": notApplicable,
namedFunction: notApplicable,
"namedFunction.constructor": notApplicable,
"namedFunction.iteration.block": notApplicable,
"namedFunction.iteration.document": notApplicable,
"namedFunction.method": notApplicable,
"namedFunction.method.iteration.class": notApplicable,
pairDelimiter: notApplicable,
regularExpression: notApplicable,
startTag: notApplicable,
statement: notApplicable,
"statement.class": notApplicable,
"statement.iteration.block": notApplicable,
"statement.iteration.document": notApplicable,
"string.multiLine": notApplicable,
"string.singleLine": notApplicable,
switchStatementSubject: notApplicable,
tags: notApplicable,
"textFragment.element": notApplicable,
"textFragment.string.multiLine": notApplicable,
"textFragment.string.singleLine": notApplicable,
"type.alias": notApplicable,
"type.argument.formal": notApplicable,
"type.argument.formal.constructor": notApplicable,
"type.argument.formal.constructor.iteration": notApplicable,
"type.argument.formal.iteration": notApplicable,
"type.argument.formal.method": notApplicable,
"type.argument.formal.method.iteration": notApplicable,
"type.cast": notApplicable,
"type.class": notApplicable,
"type.enum": notApplicable,
"type.field": notApplicable,
"type.field.iteration": notApplicable,
"type.foreach": notApplicable,
"type.interface": notApplicable,
"type.return": notApplicable,
"type.typeArgument": notApplicable,
"type.typeArgument.iteration": notApplicable,
"type.variable": notApplicable,
"value.argument.actual": notApplicable,
"value.argument.actual.iteration": notApplicable,
"value.argument.formal": notApplicable,
"value.argument.formal.constructor": notApplicable,
"value.argument.formal.constructor.iteration": notApplicable,
"value.argument.formal.iteration": notApplicable,
"value.argument.formal.method": notApplicable,
"value.argument.formal.method.iteration": notApplicable,
"value.assignment": notApplicable,
"value.attribute": notApplicable,
"value.field": notApplicable,
"value.foreach": notApplicable,
"value.mapPair": notApplicable,
"value.mapPair.iteration": notApplicable,
"value.resource": notApplicable,
"value.resource.iteration": notApplicable,
"value.return": notApplicable,
"value.return.lambda": notApplicable,
"value.typeAlias": notApplicable,
"value.variable": notApplicable,
"value.variable.pattern": notApplicable,
"value.yield": notApplicable,
};
Loading