Skip to content

Add missing xml scope facets #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Add missing xml scope facets #2852

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
694fe8b
Add missing xml scope facets
AndreasArvidsson Feb 12, 2025
689146b
Update packages/common/src/scopeSupportFacets/xml.ts
AndreasArvidsson Feb 12, 2025
2c013e8
Update packages/common/src/scopeSupportFacets/xml.ts
AndreasArvidsson Feb 12, 2025
52406d3
Clean up
AndreasArvidsson Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions data/fixtures/scopes/xml/attribute.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<name id="name">Me</name>
---

[Content] =
[Domain] = 0:6-0:15
>---------<
0| <name id="name">Me</name>

[Removal] = 0:5-0:15
>----------<
0| <name id="name">Me</name>

[Leading delimiter] = 0:5-0:6
>-<
0| <name id="name">Me</name>

[Insertion delimiter] = " "
13 changes: 9 additions & 4 deletions data/fixtures/scopes/xml/comment.block.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
<!-- aaa -->
<!--
Hello world
-->
---

[Content] =
[Removal] =
[Domain] = 0:0-0:12
>------------<
0| <!-- aaa -->
[Domain] = 0:0-2:3
>----
0| <!--
1| Hello world
2| -->
---<

[Insertion delimiter] = "\n"
10 changes: 10 additions & 0 deletions data/fixtures/scopes/xml/element.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<name id="name">Me</name>
---

[Content] =
[Removal] =
[Domain] = 0:0-0:25
>-------------------------<
0| <name id="name">Me</name>

[Insertion delimiter] = "\n"
13 changes: 13 additions & 0 deletions data/fixtures/scopes/xml/endTag.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<name id="name">Me</name>
---

[Content] =
[Removal] = 0:18-0:25
>-------<
0| <name id="name">Me</name>

[Domain] = 0:0-0:25
>-------------------------<
0| <name id="name">Me</name>

[Insertion delimiter] = " "
37 changes: 37 additions & 0 deletions data/fixtures/scopes/xml/interior.element.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
<name>Me</name>
---

[#1 Content] =
[#1 Removal] = 0:1-0:5
>----<
0| <name>Me</name>

[#1 Domain] = 0:0-0:6
>------<
0| <name>Me</name>

[#1 Insertion delimiter] = " "


[#2 Content] =
[#2 Removal] = 0:6-0:8
>--<
0| <name>Me</name>

[#2 Domain] = 0:0-0:15
>---------------<
0| <name>Me</name>

[#2 Insertion delimiter] = " "


[#3 Content] =
[#3 Removal] = 0:10-0:14
>----<
0| <name>Me</name>

[#3 Domain] = 0:8-0:15
>-------<
0| <name>Me</name>

[#3 Insertion delimiter] = " "
20 changes: 20 additions & 0 deletions data/fixtures/scopes/xml/key.attribute.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<name id="name">Me</name>
---

[Content] = 0:6-0:8
>--<
0| <name id="name">Me</name>

[Removal] = 0:6-0:9
>---<
0| <name id="name">Me</name>

[Trailing delimiter] = 0:8-0:9
>-<
0| <name id="name">Me</name>

[Domain] = 0:6-0:15
>---------<
0| <name id="name">Me</name>

[Insertion delimiter] = " "
13 changes: 13 additions & 0 deletions data/fixtures/scopes/xml/startTag.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<name id="name">Me</name>
---

[Content] =
[Removal] = 0:0-0:16
>----------------<
0| <name id="name">Me</name>

[Domain] = 0:0-0:25
>-------------------------<
0| <name id="name">Me</name>

[Insertion delimiter] = " "
10 changes: 10 additions & 0 deletions data/fixtures/scopes/xml/string.singleLine.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<name id="name">Me</name>
---

[Content] =
[Removal] =
[Domain] = 0:9-0:15
>------<
0| <name id="name">Me</name>

[Insertion delimiter] = " "
20 changes: 20 additions & 0 deletions data/fixtures/scopes/xml/tags.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<name id="name">Me</name>
---

[.1 Content] =
[.1 Removal] = 0:0-0:16
>----------------<
0| <name id="name">Me</name>

[.1 Insertion delimiter] = " "

[.2 Content] =
[.2 Removal] = 0:18-0:25
>-------<
0| <name id="name">Me</name>

[.2 Insertion delimiter] = " "

[Domain] = 0:0-0:25
>-------------------------<
0| <name id="name">Me</name>
15 changes: 15 additions & 0 deletions data/fixtures/scopes/xml/textFragment.comment.block.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<!--
Hello world
-->
---

[Content] =
[Removal] =
[Domain] = 0:0-2:3
>----
0| <!--
1| Hello world
2| -->
---<

[Insertion delimiter] = " "
10 changes: 10 additions & 0 deletions data/fixtures/scopes/xml/textFragment.element.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<name>Me</name>
---

[Content] =
[Removal] =
[Domain] = 0:6-0:8
>--<
0| <name>Me</name>

[Insertion delimiter] = " "
10 changes: 10 additions & 0 deletions data/fixtures/scopes/xml/textFragment.string.singleLine.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<name id="name"></name>
---

[Content] =
[Removal] =
[Domain] = 0:10-0:14
>----<
0| <name id="name"></name>

[Insertion delimiter] = " "
20 changes: 20 additions & 0 deletions data/fixtures/scopes/xml/value.attribute.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<name id="name">Me</name>
---

[Content] = 0:9-0:15
>------<
0| <name id="name">Me</name>

[Removal] = 0:8-0:15
>-------<
0| <name id="name">Me</name>

[Leading delimiter] = 0:8-0:9
>-<
0| <name id="name">Me</name>

[Domain] = 0:6-0:15
>---------<
0| <name id="name">Me</name>

[Insertion delimiter] = " "
Loading
Loading