Skip to content

Update failedTests.properties on success #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2025
Merged

Update failedTests.properties on success #2854

merged 1 commit into from
Feb 19, 2025

Conversation

AndreasArvidsson
Copy link
Member

I got tricked by failedTests.properties not updating when tests were successful.

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner February 12, 2025 16:48
@AndreasArvidsson AndreasArvidsson changed the title Update file with failed test names on success Update failedTests.properties on success Feb 12, 2025
@pokey
Copy link
Member

pokey commented Feb 18, 2025

Sorry, can you elaborate a bit?

@AndreasArvidsson
Copy link
Member Author

AndreasArvidsson commented Feb 19, 2025 •
edited
Loading

Certainly. Now whenever you run a test that fails we update failedTests.properties with the test names. This makes it easier to one by one open all the failed test and manually rerun and evaluate them deeper.
The problem was that I ran test that failed. I then fixed the bug,. I ran the test once again and this time they succeeded, but failedTest.properties wasn't updated so when I looked at it I still thought that the test had failed. I definitely believe that failedTests.properties should be updated on success as well.

pokey
pokey approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool didn't know bout that functionality

@pokey pokey added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit af2700f Feb 19, 2025
17 checks passed
@pokey pokey deleted the updateFailedFileOnSuccess branch February 19, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pokey pokey pokey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndreasArvidsson @pokey