Skip to content

Fix docs card for dark mode #2888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged

Fix docs card for dark mode #2888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c975cec
Fix cards for dark mode
AndreasArvidsson Apr 14, 2025
ac238bc
Update styles
AndreasArvidsson Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions packages/cursorless-org-docs/src/css/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,17 @@
}

.card {
border: 1px solid rgba(0, 0, 0, 0.175);
border: 1px solid var(--ifm-color-emphasis-300);
margin-bottom: 1rem;
}

.card-header {
background-color: #f8f9fa;
border-bottom: 1px solid rgba(0, 0, 0, 0.125);
padding: 0.5rem 1rem;
cursor: pointer;
.card.open > .card__header {
border-bottom: 1px solid var(--ifm-color-emphasis-300);
padding-bottom: 1rem;
}

.card-body {
padding: 1rem;
.pointer {
cursor: pointer;
}

.facet-name {
Expand Down
2 changes: 1 addition & 1 deletion packages/cursorless-org-docs/src/docs/user/languages/components/ScopeSupport.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export function ScopeSupport({ languageId }: Props): JSX.Element {
facets={supportedScopes}
title="Supported facets"
subtitle="These facets are supported"
expanded
open
/>

<ScopeSupportForLevel
Expand Down
14 changes: 7 additions & 7 deletions packages/cursorless-org-docs/src/docs/user/languages/components/ScopeSupportForLevel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,17 @@ interface Props {
title: string;
subtitle: string;
description?: React.ReactNode;
expanded?: boolean;
open?: boolean;
}

export function ScopeSupportForLevel({
facets,
title,
subtitle,
description,
expanded: expandedProp,
open: openProp,
}: Props): JSX.Element | null {
const [expanded, setExpanded] = useState(expandedProp ?? false);
const [open, setOpen] = useState(openProp ?? false);

const facetInfos = facets.map(
(facet): AugmentedFacetInfo => ({
Expand All @@ -46,12 +46,12 @@ export function ScopeSupportForLevel({
}

const renderBody = () => {
if (!expanded) {
if (!open) {
return null;
}

return (
<div className="card-body">
<div className="card__body">
{description && <p>{description}</p>}

{scopeTypes.map((scopeType) => {
Expand Down Expand Up @@ -79,8 +79,8 @@ export function ScopeSupportForLevel({
};

return (
<div className="card">
<div className="card-header" onClick={() => setExpanded(!expanded)}>
<div className={"card pointer" + (open ? " open" : "")}>
<div className="card__header" onClick={() => setOpen(!open)}>
<h3>{title}</h3>
{subtitle}
</div>
Expand Down
Loading