Skip to content

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Apr 16, 2025

We haven't gotten a parser for the pull requests made yet and so far we are still using the change log directory. Removing this for now and we can readd it once we actually have a parser for our pull requests.

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner April 16, 2025 15:06
@pokey
Copy link
Member

pokey commented Apr 16, 2025

Do we not want to just delete that file? Seems like you've just emptied it

@AndreasArvidsson
Copy link
Member Author

Just a provision in case we want to add something in the future, but I can remove the file instead if you prefer?

@pokey
Copy link
Member

pokey commented Apr 16, 2025

I see no reason to keep an empty file around. We can always just add it back if we need it

@AndreasArvidsson
Copy link
Member Author

Ok template file is now removed

@auscompgeek
Copy link
Member

I see no reason to keep an empty file around.

I'd imagine checking in an empty template would still override GitHub's default behaviour of using the commit message. Which if anything would probably surprise contributors.

@AndreasArvidsson
Copy link
Member Author

I see no reason to keep an empty file around.

I'd imagine checking in an empty template would still override GitHub's default behaviour of using the commit message. Which if anything would probably surprise contributors.

Probably true. We can always readd it if it's annoying though.

@AndreasArvidsson AndreasArvidsson merged commit 5747ba0 into main Apr 19, 2025
15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the removePrTemplate branch April 19, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants