-
-
Notifications
You must be signed in to change notification settings - Fork 91
Make notebook tests more reliable #2899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
86a7363
2e1ebc6
af63d4b
8a16159
e7d6f03
35507c5
e968d50
2641fae
35ed54c
ef02014
e9dbaaa
306c34c
f883ec7
2f0eeaa
43ae2ca
c94b808
9f32805
b5cbcef
4c4e24d
3a4df6d
502c43f
a675431
babfc92
03f24d1
dddfe16
ad67269
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,8 +27,8 @@ export async function launchVscodeAndRunTests(extensionTestsPath: string) { | |
"packages/cursorless-vscode/dist", | ||
); | ||
|
||
const crashDir = getEnvironmentVariableStrict("VSCODE_CRASH_DIR"); | ||
const logsDir = getEnvironmentVariableStrict("VSCODE_LOGS_DIR"); | ||
// const crashDir = getEnvironmentVariableStrict("VSCODE_CRASH_DIR"); | ||
// const logsDir = getEnvironmentVariableStrict("VSCODE_LOGS_DIR"); | ||
const useLegacyVscode = | ||
getEnvironmentVariableStrict("APP_VERSION") === "legacy"; | ||
|
||
|
@@ -81,10 +81,7 @@ export async function launchVscodeAndRunTests(extensionTestsPath: string) { | |
// don't bother. Can be re-enabled if we ever need it; on windows it only | ||
// hangs some of the time, so might be enough to get a crash dump when you | ||
// need it. | ||
launchArgs: | ||
useLegacyVscode || os.platform() === "win32" | ||
? undefined | ||
: [`--crash-reporter-directory=${crashDir}`, `--logsPath=${logsDir}`], | ||
launchArgs: ["--force-node-api-uncaught-exceptions-policy=true"], | ||
|
||
}); | ||
|
||
console.log(`Returned from "runTests" with value: ${code}`); | ||
|
Uh oh!
There was an error while loading. Please reload this page.