Skip to content

Add missing markdown scopes facets #2905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

Add missing markdown scopes facets #2905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions data/fixtures/scopes/markdown/comment.line.scope
View file
Open in desktop

This file was deleted.

17 changes: 17 additions & 0 deletions data/fixtures/scopes/markdown/textFragment.comment.block.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<!--
Hello
World
-->
---

[Content] =
[Removal] =
[Domain] = 0:0-3:3
>----
0| <!--
1| Hello
2| World
3| -->
---<

[Insertion delimiter] = " "
10 changes: 4 additions & 6 deletions packages/common/src/scopeSupportFacets/markdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import type { LanguageScopeSupportFacetMap } from "./scopeSupportFacets.types";
import { ScopeSupportFacetLevel } from "./scopeSupportFacets.types";

const { supported, unsupported, notApplicable } = ScopeSupportFacetLevel;
const { supported, notApplicable } = ScopeSupportFacetLevel;

export const markdownScopeSupport: LanguageScopeSupportFacetMap = {
"comment.line": supported,
"comment.block": supported,
"textFragment.comment.block": supported,

section: supported,
"section.iteration.document": supported,
Expand All @@ -17,10 +17,6 @@ export const markdownScopeSupport: LanguageScopeSupportFacetMap = {
"collectionItem.unenclosed": supported,
list: supported,

// Unsupported
"textFragment.comment.line": unsupported,
"textFragment.comment.block": unsupported,

// Not applicable

anonymousFunction: notApplicable,
Expand Down Expand Up @@ -53,6 +49,7 @@ export const markdownScopeSupport: LanguageScopeSupportFacetMap = {
"className.iteration.document": notApplicable,
"collectionItem.unenclosed.iteration": notApplicable,
command: notApplicable,
"comment.line": notApplicable,
"condition.doWhile": notApplicable,
"condition.for": notApplicable,
"condition.if": notApplicable,
Expand Down Expand Up @@ -133,6 +130,7 @@ export const markdownScopeSupport: LanguageScopeSupportFacetMap = {
"textFragment.element": notApplicable,
"textFragment.string.multiLine": notApplicable,
"textFragment.string.singleLine": notApplicable,
"textFragment.comment.line": notApplicable,
"type.alias": notApplicable,
"type.argument.formal": notApplicable,
"type.argument.formal.constructor": notApplicable,
Expand Down
Loading