Skip to content

Hide output from visible text editors #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Hide output from visible text editors #2918

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99c843e
Hide output from visible text editors
AndreasArvidsson May 21, 2025
820964e
Also filter active editor
AndreasArvidsson May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/cursorless-vscode/src/ide/vscode/VscodeIDE.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,16 @@ export class VscodeIDE implements IDE {
}

private getActiveTextEditor() {
return window.activeTextEditor != null
return window.activeTextEditor != null &&
isValidEditor(window.activeTextEditor)
? this.fromVscodeEditor(window.activeTextEditor)
: undefined;
}

get visibleTextEditors(): VscodeTextEditorImpl[] {
return window.visibleTextEditors.map((e) => this.fromVscodeEditor(e));
return window.visibleTextEditors
.filter(isValidEditor)
.map((e) => this.fromVscodeEditor(e));
}

get visibleNotebookEditors(): NotebookEditor[] {
Expand Down Expand Up @@ -248,3 +251,7 @@ export class VscodeIDE implements IDE {
return () => pull(this.extensionContext.subscriptions, ...disposables);
}
}

function isValidEditor(editor: vscode.TextEditor): boolean {
return editor.document.uri.scheme !== "output";
}
Loading