Skip to content

Update insertion delimiter for document scope #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

Update insertion delimiter for document scope #2929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions data/fixtures/recorded/positions/bringHarpToAfterFile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ initialState:
finalState:
documentContents: |-
hello world

hello
selections:
- anchor: {line: 0, character: 0}
Expand Down
5 changes: 3 additions & 2 deletions data/fixtures/recorded/positions/bringWhaleToBeforeFile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ initialState:
finalState:
documentContents: |-
world

hello world
selections:
- anchor: {line: 1, character: 0}
active: {line: 1, character: 0}
- anchor: {line: 2, character: 0}
active: {line: 2, character: 0}
1 change: 1 addition & 0 deletions data/fixtures/recorded/selectionTypes/bringHarpToAfterFile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ initialState:
finalState:
documentContents: |-
hello world

hello
selections:
- anchor: {line: 0, character: 11}
Expand Down
5 changes: 3 additions & 2 deletions data/fixtures/recorded/selectionTypes/bringWhaleToBeforeFile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ initialState:
finalState:
documentContents: |-
world

hello world
selections:
- anchor: {line: 1, character: 11}
active: {line: 1, character: 11}
- anchor: {line: 2, character: 11}
active: {line: 2, character: 11}
2 changes: 1 addition & 1 deletion data/fixtures/scopes/textual/document.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ ccc
5| ccc
---<

[Insertion delimiter] = "\n"
[Insertion delimiter] = "\n\n"
2 changes: 1 addition & 1 deletion packages/cursorless-engine/src/processTargets/targets/DocumentTarget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { PlainTarget } from "./PlainTarget";
export class DocumentTarget extends BaseTarget<CommonTargetParameters> {
type = "DocumentTarget";
textualType: TextualType = "line";
insertionDelimiter = "\n";
insertionDelimiter = "\n\n";

constructor(parameters: CommonTargetParameters) {
super(parameters);
Expand Down
Loading