Skip to content

Assert that we have an active editor before taking snapshot #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
+7 −1
Merged

Assert that we have an active editor before taking snapshot #2932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/common/src/testUtil/getSnapshotForComparison.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,18 @@ export async function getSnapshotForComparison(
}
}

const editor = spyIde.activeTextEditor;

if (editor == null) {
throw new Error("No active text editor found in SpyIDE");
}

// FIXME Visible ranges are not asserted, see:
// https://github.com/cursorless-dev/cursorless/issues/160
const { visibleRanges, ...resultState } = await takeSnapshot(
excludeFields,
[],
spyIde.activeTextEditor!,
editor,
spyIde,
marks,
);
Expand Down
Loading