Skip to content

Add some missing csharp scope facets #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 29, 2025
Merged

Add some missing csharp scope facets #2937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5e28db1
Added argument list scope
AndreasArvidsson May 29, 2025
9a22fe7
Add arguments
AndreasArvidsson May 29, 2025
21047ff
Working on branches
AndreasArvidsson May 29, 2025
c8c120e
Added tests for branch
AndreasArvidsson May 29, 2025
d3f28b8
Clean up
AndreasArvidsson May 29, 2025
bccf6da
Added not applicable
AndreasArvidsson May 29, 2025
326429c
Merge branch 'main' into csharpScopes
AndreasArvidsson May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions data/fixtures/scopes/csharp/argument.actual.constructor.iteration.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
new Foo(a, b);
---

[Range] = 0:8-0:12
>----<
0| new Foo(a, b);

[Domain] = 0:0-0:13
>-------------<
0| new Foo(a, b);
33 changes: 33 additions & 0 deletions data/fixtures/scopes/csharp/argument.actual.constructor.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
new Foo(a, b);
---

[#1 Content] =
[#1 Domain] = 0:8-0:9
>-<
0| new Foo(a, b);

[#1 Removal] = 0:8-0:11
>---<
0| new Foo(a, b);

[#1 Trailing delimiter] = 0:9-0:11
>--<
0| new Foo(a, b);

[#1 Insertion delimiter] = ", "


[#2 Content] =
[#2 Domain] = 0:11-0:12
>-<
0| new Foo(a, b);

[#2 Removal] = 0:9-0:12
>---<
0| new Foo(a, b);

[#2 Leading delimiter] = 0:9-0:11
>--<
0| new Foo(a, b);

[#2 Insertion delimiter] = ", "
44 changes: 44 additions & 0 deletions data/fixtures/scopes/csharp/argument.actual.constructor2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
new Foo(
a,
b
);
---

[#1 Content] =
[#1 Domain] = 1:4-1:5
>-<
1| a,

[#1 Removal] = 1:4-2:4
>--
1| a,
2| b
----<

[#1 Trailing delimiter] = 1:5-2:4
>-
1| a,
2| b
----<

[#1 Insertion delimiter] = ",\n"


[#2 Content] =
[#2 Domain] = 2:4-2:5
>-<
2| b

[#2 Removal] = 1:5-2:5
>-
1| a,
2| b
-----<

[#2 Leading delimiter] = 1:5-2:4
>-
1| a,
2| b
----<

[#2 Insertion delimiter] = ",\n"
10 changes: 10 additions & 0 deletions data/fixtures/scopes/csharp/argument.actual.method.iteration.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
foo.bar(a, b);
---

[Range] = 0:8-0:12
>----<
0| foo.bar(a, b);

[Domain] = 0:0-0:13
>-------------<
0| foo.bar(a, b);
33 changes: 33 additions & 0 deletions data/fixtures/scopes/csharp/argument.actual.method.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
foo.bar(a, b);
---

[#1 Content] =
[#1 Domain] = 0:8-0:9
>-<
0| foo.bar(a, b);

[#1 Removal] = 0:8-0:11
>---<
0| foo.bar(a, b);

[#1 Trailing delimiter] = 0:9-0:11
>--<
0| foo.bar(a, b);

[#1 Insertion delimiter] = ", "


[#2 Content] =
[#2 Domain] = 0:11-0:12
>-<
0| foo.bar(a, b);

[#2 Removal] = 0:9-0:12
>---<
0| foo.bar(a, b);

[#2 Leading delimiter] = 0:9-0:11
>--<
0| foo.bar(a, b);

[#2 Insertion delimiter] = ", "
44 changes: 44 additions & 0 deletions data/fixtures/scopes/csharp/argument.actual.method2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
foo.bar(
a,
b
);
---

[#1 Content] =
[#1 Domain] = 1:4-1:5
>-<
1| a,

[#1 Removal] = 1:4-2:4
>--
1| a,
2| b
----<

[#1 Trailing delimiter] = 1:5-2:4
>-
1| a,
2| b
----<

[#1 Insertion delimiter] = ",\n"


[#2 Content] =
[#2 Domain] = 2:4-2:5
>-<
2| b

[#2 Removal] = 1:5-2:5
>-
1| a,
2| b
-----<

[#2 Leading delimiter] = 1:5-2:4
>-
1| a,
2| b
----<

[#2 Insertion delimiter] = ",\n"
12 changes: 12 additions & 0 deletions data/fixtures/scopes/csharp/argument.formal.constructor.iteration.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
class MyClass {
MyClass(int a, int b) {}
}
---

[Range] = 1:12-1:24
>------------<
1| MyClass(int a, int b) {}

[Domain] = 1:4-1:28
>------------------------<
1| MyClass(int a, int b) {}
35 changes: 35 additions & 0 deletions data/fixtures/scopes/csharp/argument.formal.constructor.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
class MyClass {
MyClass(int a, int b) {}
}
---

[#1 Content] =
[#1 Domain] = 1:12-1:17
>-----<
1| MyClass(int a, int b) {}

[#1 Removal] = 1:12-1:19
>-------<
1| MyClass(int a, int b) {}

[#1 Trailing delimiter] = 1:17-1:19
>--<
1| MyClass(int a, int b) {}

[#1 Insertion delimiter] = ", "


[#2 Content] =
[#2 Domain] = 1:19-1:24
>-----<
1| MyClass(int a, int b) {}

[#2 Removal] = 1:17-1:24
>-------<
1| MyClass(int a, int b) {}

[#2 Leading delimiter] = 1:17-1:19
>--<
1| MyClass(int a, int b) {}

[#2 Insertion delimiter] = ", "
46 changes: 46 additions & 0 deletions data/fixtures/scopes/csharp/argument.formal.constructor2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
class MyClass {
MyClass(
int a,
int b
) {}
}
---

[#1 Content] =
[#1 Domain] = 2:8-2:13
>-----<
2| int a,

[#1 Removal] = 2:8-3:8
>------
2| int a,
3| int b
--------<

[#1 Trailing delimiter] = 2:13-3:8
>-
2| int a,
3| int b
--------<

[#1 Insertion delimiter] = ",\n"


[#2 Content] =
[#2 Domain] = 3:8-3:13
>-----<
3| int b

[#2 Removal] = 2:13-3:13
>-
2| int a,
3| int b
-------------<

[#2 Leading delimiter] = 2:13-3:8
>-
2| int a,
3| int b
--------<

[#2 Insertion delimiter] = ",\n"
12 changes: 12 additions & 0 deletions data/fixtures/scopes/csharp/argument.formal.method.iteration.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
class MyClass {
void foo(int a, int b) {}
}
---

[Range] = 1:13-1:25
>------------<
1| void foo(int a, int b) {}

[Domain] = 1:4-1:29
>-------------------------<
1| void foo(int a, int b) {}
35 changes: 35 additions & 0 deletions data/fixtures/scopes/csharp/argument.formal.method.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
class MyClass {
void foo(int a, int b) {}
}
---

[#1 Content] =
[#1 Domain] = 1:13-1:18
>-----<
1| void foo(int a, int b) {}

[#1 Removal] = 1:13-1:20
>-------<
1| void foo(int a, int b) {}

[#1 Trailing delimiter] = 1:18-1:20
>--<
1| void foo(int a, int b) {}

[#1 Insertion delimiter] = ", "


[#2 Content] =
[#2 Domain] = 1:20-1:25
>-----<
1| void foo(int a, int b) {}

[#2 Removal] = 1:18-1:25
>-------<
1| void foo(int a, int b) {}

[#2 Leading delimiter] = 1:18-1:20
>--<
1| void foo(int a, int b) {}

[#2 Insertion delimiter] = ", "
46 changes: 46 additions & 0 deletions data/fixtures/scopes/csharp/argument.formal.method2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
class MyClass {
void foo(
int a,
int b
) {}
}
---

[#1 Content] =
[#1 Domain] = 2:8-2:13
>-----<
2| int a,

[#1 Removal] = 2:8-3:8
>------
2| int a,
3| int b
--------<

[#1 Trailing delimiter] = 2:13-3:8
>-
2| int a,
3| int b
--------<

[#1 Insertion delimiter] = ",\n"


[#2 Content] =
[#2 Domain] = 3:8-3:13
>-----<
3| int b

[#2 Removal] = 2:13-3:13
>-
2| int a,
3| int b
-------------<

[#2 Leading delimiter] = 2:13-3:8
>-
2| int a,
3| int b
--------<

[#2 Insertion delimiter] = ",\n"
13 changes: 13 additions & 0 deletions data/fixtures/scopes/csharp/argumentList.actual.constructor.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
new Foo();
---

[Content] =
[Removal] = 0:8-0:8
><
0| new Foo();

[Domain] = 0:0-0:9
>---------<
0| new Foo();

[Insertion delimiter] = ""
13 changes: 13 additions & 0 deletions data/fixtures/scopes/csharp/argumentList.actual.constructor2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
new Foo(a, b);
---

[Content] =
[Removal] = 0:8-0:12
>----<
0| new Foo(a, b);

[Domain] = 0:0-0:13
>-------------<
0| new Foo(a, b);

[Insertion delimiter] = ", "
Loading
Loading