Skip to content

Increase timeout for opening new notebook editors in testing #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2025
Merged

Increase timeout for opening new notebook editors in testing #2938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38bf287
Increase timeout for opening new notebook editors in testing
AndreasArvidsson May 29, 2025
663a180
Clean up
AndreasArvidsson May 29, 2025
3091439
update
AndreasArvidsson May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/cursorless-vscode-e2e/src/suite/crossCellsSetSelection.vscode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { sleep } from "@cursorless/common";
import {
getCursorlessApi,
openNewNotebookEditor,
Expand All @@ -19,6 +20,8 @@ async function runTest() {

await openNewNotebookEditor(['"hello"', '"world"']);

await sleep(200);

await hatTokenMap.allocateHats();

await runCursorlessCommand({
Expand Down
5 changes: 2 additions & 3 deletions packages/vscode-common/src/testUtil/openNewEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,14 +103,13 @@ export async function openNewNotebookEditor(
return document;
}

function waitForEditorToOpen() {
function waitForEditorToOpen(): Promise<void> {
return new Promise<void>((resolve, reject) => {
let count = 0;
const interval = setInterval(() => {
if (vscode.window.activeTextEditor != null) {
clearInterval(interval);
// Give it a moment to settle
setTimeout(resolve, 100);
resolve();
} else {
count++;
if (count === 20) {
Expand Down
Loading