-
-
Notifications
You must be signed in to change notification settings - Fork 91
Updated contributor docs with info about adding language.mdx #2955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
999cb24
Updated contributor docs wit info about adding language.mdx
AndreasArvidsson a239277
Update link
AndreasArvidsson cf429de
Update how links are resolved
AndreasArvidsson c75c737
Cleanup
AndreasArvidsson 751d168
Elaborate on comment
AndreasArvidsson 548314f
Clean up
AndreasArvidsson adefd57
Throw unbroken anchors
AndreasArvidsson 906a49e
Only rewrite folders
AndreasArvidsson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -300,7 +300,7 @@ cursorless.nvim/.busted | |
### Running lua unit tests | ||
|
||
Many of the cursorless.nvim lua functions are run in order to complete Cursorless actions and so are already | ||
indirectly tested by the tests described in the [previous section](#3-cursorless-tests-for-neovim). Nevertheless, we run | ||
indirectly tested by the tests described in the [previous section](#running-neovim-tests-locally). Nevertheless, we run | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix broken link |
||
more specific unit tests in order to give better visibility into exactly which functions are failing. | ||
The [busted](https://github.com/lunarmodules/busted) framework is used to test lua functions defined in cursorless.nvim. | ||
This relies on a `cursorless.nvim/.busted` file which directs busted to use a lua interpreter and test specifications files: | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why this is required. Linking to a markdown file between contributing and user works fine, but not a folder.
../user/languages
incorrectly got resolved as/docs/contributing/user/languages
. This problem does not occur with files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could have something to do with this? But I'm not sure why files work and not folders.
https://docusaurus.io/docs/markdown-features/links#:~:text=Markdown%20file%20references,use%20URL%20links.