Replace private.switchStatementSubject with value scope
#2999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
A week has passed with no feedback. I will go ahead and merge this now. |
cursorless-bot
pushed a commit
that referenced
this pull request
Jul 7, 2025
* We're already using `value` for the collection in for-each statements: - https://github.com/cursorless-dev/cursorless/blob/d55c744091394d8840a17e04ef8b7d21f03068b3/data/fixtures/scopes/javascript.core/value.foreach.scope * Most of the tree sitter parsers call this field `value`. The other alternative that's commonly used is `condition`, but we're already using that in switch cases and I want to avoid conflicts. - https://github.com/cursorless-dev/cursorless/blob/d55c744091394d8840a17e04ef8b7d21f03068b3/queries/javascript.core.scm#L614 Since this scope is private we're not going to do any migration or deprecation. It will just be removed. The this pull requests adds `value` scope support for the switch subject though. With that said I'm going to leave this open for a week in case someone has input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valuefor the collection in for-each statements:value. The other alternative that's commonly used iscondition, but we're already using that in switch cases and I want to avoid conflicts.cursorless/queries/javascript.core.scm
Line 614 in d55c744
Since this scope is private we're not going to do any migration or deprecation. It will just be removed. The this pull requests adds
valuescope support for the switch subject though.With that said I'm going to leave this open for a week in case someone has input.