Skip to content

Added name and value iteration scope facets #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 1, 2025
Merged

Added name and value iteration scope facets #3000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
051dba3
Added more iteration scope facets to name and value
AndreasArvidsson Jun 30, 2025
a5e0d75
c/cpp
AndreasArvidsson Jun 30, 2025
9bf236f
javascript
AndreasArvidsson Jun 30, 2025
7cb70eb
js statement
AndreasArvidsson Jun 30, 2025
42bee38
csharp
AndreasArvidsson Jun 30, 2025
a1d6d09
More csharp
AndreasArvidsson Jun 30, 2025
04e76ef
css
AndreasArvidsson Jun 30, 2025
6ba8207
talon
AndreasArvidsson Jun 30, 2025
cbc7455
talon test
AndreasArvidsson Jun 30, 2025
9ab4533
java
AndreasArvidsson Jun 30, 2025
66ab205
python
AndreasArvidsson Jun 30, 2025
1dabef0
Update class tests
AndreasArvidsson Jul 1, 2025
e3c2a3e
rename
AndreasArvidsson Jul 1, 2025
cd840e3
reorder
AndreasArvidsson Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions data/fixtures/recorded/languages/talon/clearEveryValue5.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,9 @@ initialState:
finalState:
documentContents: |-
foo:

bar = 1

baz:
selections:
- anchor: {line: 1, character: 4}
active: {line: 1, character: 4}
- anchor: {line: 3, character: 5}
active: {line: 3, character: 5}
37 changes: 7 additions & 30 deletions data/fixtures/scopes/c/class.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,10 @@
struct aaa { int bbb; };

typedef struct { int fff; } ggg;
struct Foo {};
---

[#1 Content] =
[#1 Domain] = 0:0-0:24
>------------------------<
0| struct aaa { int bbb; };

[#1 Removal] = 0:0-2:0
>------------------------
0| struct aaa { int bbb; };
1|
2| typedef struct { int fff; } ggg;
<

[#1 Insertion delimiter] = "\n\n"


[#2 Content] =
[#2 Domain] = 2:0-2:32
>--------------------------------<
2| typedef struct { int fff; } ggg;

[#2 Removal] = 0:24-2:32
>
0| struct aaa { int bbb; };
1|
2| typedef struct { int fff; } ggg;
--------------------------------<
[Content] =
[Removal] =
[Domain] = 0:0-0:14
>--------------<
0| struct Foo {};

[#2 Insertion delimiter] = "\n\n"
[Insertion delimiter] = "\n\n"
37 changes: 7 additions & 30 deletions data/fixtures/scopes/c/class2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,10 @@
union bbb { int ccc; };

typedef union { int hhh; } iii;
union Foo {};
---

[#1 Content] =
[#1 Domain] = 0:0-0:23
>-----------------------<
0| union bbb { int ccc; };

[#1 Removal] = 0:0-2:0
>-----------------------
0| union bbb { int ccc; };
1|
2| typedef union { int hhh; } iii;
<

[#1 Insertion delimiter] = "\n\n"


[#2 Content] =
[#2 Domain] = 2:0-2:31
>-------------------------------<
2| typedef union { int hhh; } iii;

[#2 Removal] = 0:23-2:31
>
0| union bbb { int ccc; };
1|
2| typedef union { int hhh; } iii;
-------------------------------<
[Content] =
[Removal] =
[Domain] = 0:0-0:13
>-------------<
0| union Foo {};

[#2 Insertion delimiter] = "\n\n"
[Insertion delimiter] = "\n\n"
37 changes: 7 additions & 30 deletions data/fixtures/scopes/c/class3.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,10 @@
enum ccc { ddd, eee };

typedef enum { jjj, kkk } lll;
enum Foo {};
---

[#1 Content] =
[#1 Domain] = 0:0-0:22
>----------------------<
0| enum ccc { ddd, eee };

[#1 Removal] = 0:0-2:0
>----------------------
0| enum ccc { ddd, eee };
1|
2| typedef enum { jjj, kkk } lll;
<

[#1 Insertion delimiter] = "\n\n"


[#2 Content] =
[#2 Domain] = 2:0-2:30
>------------------------------<
2| typedef enum { jjj, kkk } lll;

[#2 Removal] = 0:22-2:30
>
0| enum ccc { ddd, eee };
1|
2| typedef enum { jjj, kkk } lll;
------------------------------<
[Content] =
[Removal] =
[Domain] = 0:0-0:12
>------------<
0| enum Foo {};

[#2 Insertion delimiter] = "\n\n"
[Insertion delimiter] = "\n\n"
10 changes: 10 additions & 0 deletions data/fixtures/scopes/c/class4.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
typedef struct { } Foo;
---

[Content] =
[Removal] =
[Domain] = 0:0-0:23
>-----------------------<
0| typedef struct { } Foo;

[Insertion delimiter] = "\n\n"
10 changes: 10 additions & 0 deletions data/fixtures/scopes/c/class5.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
typedef union { } Foo;
---

[Content] =
[Removal] =
[Domain] = 0:0-0:22
>----------------------<
0| typedef union { } Foo;

[Insertion delimiter] = "\n\n"
10 changes: 10 additions & 0 deletions data/fixtures/scopes/c/class6.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
typedef enum { } Foo;
---

[Content] =
[Removal] =
[Domain] = 0:0-0:21
>---------------------<
0| typedef enum { } Foo;

[Insertion delimiter] = "\n\n"
24 changes: 24 additions & 0 deletions data/fixtures/scopes/c/name.iteration.class.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
struct Foo { };

typedef struct { } Bar;
---

[#1 Range] =
[#1 Domain] = 0:0-2:23
>---------------
0| struct Foo { };
1|
2| typedef struct { } Bar;
-----------------------<


[#2 Range] =
[#2 Domain] = 0:12-0:13
>-<
0| struct Foo { };


[#3 Range] =
[#3 Domain] = 2:16-2:17
>-<
2| typedef struct { } Bar;
24 changes: 24 additions & 0 deletions data/fixtures/scopes/c/name.iteration.class2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
union Foo { };

typedef union { } Bar;
---

[#1 Range] =
[#1 Domain] = 0:0-2:22
>--------------
0| union Foo { };
1|
2| typedef union { } Bar;
----------------------<


[#2 Range] =
[#2 Domain] = 0:11-0:12
>-<
0| union Foo { };


[#3 Range] =
[#3 Domain] = 2:15-2:16
>-<
2| typedef union { } Bar;
13 changes: 13 additions & 0 deletions data/fixtures/scopes/c/value.iteration.block.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
if (true) { }
---

[#1 Range] =
[#1 Domain] = 0:0-0:13
>-------------<
0| if (true) { }


[#2 Range] =
[#2 Domain] = 0:11-0:12
>-<
0| if (true) { }
13 changes: 13 additions & 0 deletions data/fixtures/scopes/c/value.iteration.block2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
void foo() { }
---

[#1 Range] =
[#1 Domain] = 0:0-0:14
>--------------<
0| void foo() { }


[#2 Range] =
[#2 Domain] = 0:12-0:13
>-<
0| void foo() { }
24 changes: 24 additions & 0 deletions data/fixtures/scopes/c/value.iteration.class.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
struct Foo { };

typedef struct { } Bar;
---

[#1 Range] =
[#1 Domain] = 0:0-2:23
>---------------
0| struct Foo { };
1|
2| typedef struct { } Bar;
-----------------------<


[#2 Range] =
[#2 Domain] = 0:12-0:13
>-<
0| struct Foo { };


[#3 Range] =
[#3 Domain] = 2:16-2:17
>-<
2| typedef struct { } Bar;
24 changes: 24 additions & 0 deletions data/fixtures/scopes/c/value.iteration.class2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
union Foo { };

typedef union { } Bar;
---

[#1 Range] =
[#1 Domain] = 0:0-2:22
>--------------
0| union Foo { };
1|
2| typedef union { } Bar;
----------------------<


[#2 Range] =
[#2 Domain] = 0:11-0:12
>-<
0| union Foo { };


[#3 Range] =
[#3 Domain] = 2:15-2:16
>-<
2| typedef union { } Bar;
12 changes: 12 additions & 0 deletions data/fixtures/scopes/c/value.iteration.document.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@

int foo;

---

[Range] =
[Domain] = 0:0-2:0
>
0|
1| int foo;
2|
<
34 changes: 7 additions & 27 deletions data/fixtures/scopes/cpp/class.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,10 @@
class aaa { int bbb; };
enum class ccc { ddd, eee };
class Foo {};
---

[#1 Content] =
[#1 Domain] = 0:0-0:23
>-----------------------<
0| class aaa { int bbb; };
[Content] =
[Removal] =
[Domain] = 0:0-0:13
>-------------<
0| class Foo {};

[#1 Removal] = 0:0-1:0
>-----------------------
0| class aaa { int bbb; };
1| enum class ccc { ddd, eee };
<

[#1 Insertion delimiter] = "\n\n"


[#2 Content] =
[#2 Domain] = 1:0-1:28
>----------------------------<
1| enum class ccc { ddd, eee };

[#2 Removal] = 0:23-1:28
>
0| class aaa { int bbb; };
1| enum class ccc { ddd, eee };
----------------------------<

[#2 Insertion delimiter] = "\n\n"
[Insertion delimiter] = "\n\n"
10 changes: 10 additions & 0 deletions data/fixtures/scopes/cpp/class2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
enum class Foo {};
---

[Content] =
[Removal] =
[Domain] = 0:0-0:18
>------------------<
0| enum class Foo {};

[Insertion delimiter] = "\n\n"
13 changes: 13 additions & 0 deletions data/fixtures/scopes/cpp/name.iteration.class.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
class Foo { };
---

[#1 Range] =
[#1 Domain] = 0:0-0:14
>--------------<
0| class Foo { };


[#2 Range] =
[#2 Domain] = 0:11-0:12
>-<
0| class Foo { };
Loading
Loading