Skip to content

Better handling of quick pick with whitespace #3045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

Better handling of quick pick with whitespace #3045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions packages/cursorless-vscode/src/ide/vscode/vscodeShowQuickPick.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,12 @@ export function vscodeShowQuickPick(
}

if (options?.defaultValue != null) {
quickPick.activeItems = quickPickItems.filter(
const activeItem = quickPickItems.find(
(item) => item.value === options.defaultValue,
);
if (activeItem != null) {
quickPick.activeItems = [activeItem];
}
}

if (options?.unknownValues) {
Expand All @@ -45,19 +48,17 @@ export function vscodeShowQuickPick(
: "Add new value '{}' →";

quickPick.onDidChangeValue(() => {
quickPick.items = [
...quickPickItems,

// INJECT user values into proposed values
...(items.includes(quickPick.value) || quickPick.value.trim() === ""
? []
const value = quickPick.value.trim();
quickPick.items =
value === "" || items.includes(value)
? quickPickItems
: [
...quickPickItems,
{
label: newValueTemplate.replace("{}", quickPick.value),
value: quickPick.value,
label: newValueTemplate.replace("{}", value),
value,
},
]),
];
];
});
}

Expand Down
Loading