Skip to content

Conversation

AndreasArvidsson
Copy link
Member

Fixes #3067

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong to
me. I would argue lang scope should take precedence over generic text scope. Why are we even matching lang scope here?

That being said, I'm not going to get in the way of merging to get the unit test in and filing an issue to follow up and understand what's going on

@AndreasArvidsson
Copy link
Member Author

AndreasArvidsson commented Aug 12, 2025

We do have a sorting algorithm based based on the domain. I don't think it matters to much to the us sir how the scope is implemented. For example why would string be down prioritize compared to other scopes?

It also makes sense to have the new order since we know that if the domain of a surrounding pair interior is always larger than the content range. Until we find an actual use case that doesn't work I think this solution is actually quite decent.

@AndreasArvidsson AndreasArvidsson merged commit 4fe0d65 into main Aug 12, 2025
15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the interior branch August 12, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typescript: "inside" broken for strings inside ternary branches
2 participants