Skip to content

Add GDScript to supported languages #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
+27 −0
Draft

Add GDScript to supported languages #3092

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4436ea8
Initial setup
rinOfTheStars Sep 7, 2025
659337d
gdscript doesnt have explicit interfaces, so this is an easy one
rinOfTheStars Sep 7, 2025
18196ca
formatting changes
rinOfTheStars Sep 7, 2025
d44bfae
Merge branch 'cursorless-dev:main' into gdscript-support
rinOfTheStars Oct 5, 2025
2861cb9
add lang doc file
rinOfTheStars Oct 11, 2025
92e746f
disable no-unused-vars err for one line bc yes, I know they're unused…
rinOfTheStars Oct 11, 2025
7292978
disable no-unused-vars err for one line bc yes, I know they're unused…
rinOfTheStars Oct 11, 2025
70d9d90
Merge remote-tracking branch 'refs/remotes/origin/gdscript-support' i…
rinOfTheStars Oct 11, 2025
5a8338f
i have no clue what the syntax to disable a specific rule is, apparen…
rinOfTheStars Oct 11, 2025
73b29a0
run prettier and fix comment formatting as suggested
rinOfTheStars Oct 13, 2025
769e9c5
hand-written scope files
rinOfTheStars Oct 18, 2025
9ae1308
Merge branch 'cursorless-dev:main' into gdscript-support
rinOfTheStars Oct 18, 2025
af382a7
Merge branch 'gdscript-support' of https://github.com/rinOfTheStars/c…
rinOfTheStars Oct 18, 2025
400fa05
run precommit
rinOfTheStars Oct 18, 2025
20be27f
Revert "hand-written scope files"
rinOfTheStars Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/common/src/extensionDependencies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export const extensionDependencies = [
"mrob95.vscode-talonscript", // talon
"jrieken.vscode-tree-sitter-query", // scm
"mathiasfrohlich.kotlin", // kotlin
"geequlim.godot-tools", //gdscript

// Necessary for the `drink cell` and `pour cell` tests
"ms-toolsai.jupyter",
Expand Down
19 changes: 19 additions & 0 deletions packages/common/src/scopeSupportFacets/gdscript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import type { LanguageScopeSupportFacetMap } from "./scopeSupportFacets.types";
import { ScopeSupportFacetLevel } from "./scopeSupportFacets.types";

//eslint-disable-next-line
const { supported, unsupported, notApplicable } = ScopeSupportFacetLevel;

export const gdscriptScopeSupport: LanguageScopeSupportFacetMap = {
// not applicable
"statement.interface": notApplicable,
"statement.field.interface": notApplicable,
"statement.iteration.interface": notApplicable,
"name.interface": notApplicable,
"name.field.interface": notApplicable,
"name.iteration.interface": notApplicable,
"type.field.interface": notApplicable,
"type.interface": notApplicable,
"type.iteration.interface": notApplicable,
"interior.interface": notApplicable,
};
2 changes: 2 additions & 0 deletions packages/common/src/scopeSupportFacets/languageScopeSupport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { csharpScopeSupport } from "./csharp";
import { cssScopeSupport } from "./css";
import { dartScopeSupport } from "./dart";
import { goScopeSupport } from "./go";
import { gdscriptScopeSupport } from "./gdscript";
import { htmlScopeSupport } from "./html";
import { javaScopeSupport } from "./java";
import { javascriptScopeSupport } from "./javascript";
Expand Down Expand Up @@ -45,6 +46,7 @@ export const languageScopeSupport: StringRecord<LanguageScopeSupportFacetMap> =
css: cssScopeSupport,
dart: dartScopeSupport,
go: goScopeSupport,
gdscript: gdscriptScopeSupport,
html: htmlScopeSupport,
java: javaScopeSupport,
javascript: javascriptScopeSupport,
Expand Down
5 changes: 5 additions & 0 deletions packages/cursorless-org-docs/src/docs/user/languages/gdscript.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { Language } from "./components/Language";

# GDScript

<Language languageId="gdscript" />
Empty file added queries/gdscript.scm
View file
Open in desktop
Copy link
Member

@AndreasArvidsson AndreasArvidsson Oct 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of committing an empty file. Please add at least one scope to it. You can do something simple like comment for example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to need to make another PR to add another codium cli naming related fix first so I can more easily do that, but once that's done that should be easy enough

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #3093 for the fixes mentioned above

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow why you would need to update the scripts first? Personally I don't use those scripts at all.
You just run the Cursorless extension from inside of vscode/codium when developing.

Copy link
Contributor Author

@rinOfTheStars rinOfTheStars Oct 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's required in this very specific instance because gdscript isn't supported by prod yet, and I can't get developing from the cursorlessDevelopment dev profile to work for some reason. Probably need to delete and remake the thing?

I can probably bootstrap a local version using the scripts update I made by building from this PR, at the very least, so getting that PR in isn't urgent for now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would definitely recommend getting the development profile working. That will hot reload and apply any changes whenever you save a scm file.
Removing the profile/sandbox and installing it again sounds like something to try.

Empty file.
Loading