This repository was archived by the owner on Jun 19, 2024. It is now read-only.
Fix math error in clipping code#199
Open
khenriks wants to merge 1 commit intocurtacircuitos:masterfrom
Open
Conversation
ymax should be the ceil of the argument, not the floor.
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
=======================================
Coverage 68.44% 68.44%
=======================================
Files 27 27
Lines 6050 6050
Branches 1094 1094
=======================================
Hits 4141 4141
Misses 1645 1645
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ymax should be the ceil of the argument, not the floor.