Conversation
|
@fedorovdg or @Macket would you mind to take a look and let me know if I should edit anything? |
Make sure the tests can be ran easily. This is the first of a list of change aiming at improving the test setup. We will try to keep the changes simple and iterate rather than making a giant pull request that would be painful to be reviewed and merged. Note that the `rpcUrls.test.js` file was added back to tracking and leverages `process.env`. Alternatively we could add dotenv as a dev dependency and use (untracked) `.env` files for RPC URLs. A lot of tests are still failing but at least some pass. Fixing tests will be addressed in follow up pull requests. Tested with both Hardhat and Anvil exporting `ETH_RPC` as: ``` export ETH_RPC=http://127.0.0.1:8545 ``` In follow up pull requests we want to: - fix or skip broken tests - run tests from the CI
AndreMiras
force-pushed
the
feature/basic_test_setup
branch
from
a60fd64 to
e11f08a
Compare
DanielSchiavini
left a comment
DanielSchiavini
left a comment
There was a problem hiding this comment.
I've tried to get the tests to run in #389
however, even locally, I didn't manage to make them actually pass
Hey @DanielSchiavini, Thanks for getting back to me and for sharing the draft 🙏 I agree, it's a huge task and I believe we can get there step by step. I also noticed that we're running tests across all possible pools, but I don't think it's necessary for decent library coverage. I'd like to focus on refining that part of the tests. As I mentioned, addressing everything at once could make it hard to move forward. Once this PR is merged, I can work on getting a smaller subset of tests running and demonstrate it through CI. Then, as more tests are fixed, we can gradually expand coverage and integrate that into the CI process. Would you mind merging this PR if you think it’s a small step toward achieving the larger goal? |
DanielSchiavini
left a comment
DanielSchiavini
left a comment
There was a problem hiding this comment.
It looks fine but please wait for @Macket, he has a week off
2 participants
Make sure the tests can be ran easily.
This is the first of a list of change aiming at improving the test setup. We will try to keep the changes simple and iterate rather than making a giant pull request that would be painful to be reviewed and merged.
Note that the
rpcUrls.test.jsfile was added back to tracking and leveragesprocess.env. Alternatively we could add dotenv as a dev dependency and use (untracked).envfiles for RPC URLs.A lot of tests are still failing but at least some pass. Fixing tests will be addressed in follow up pull requests.
Tested with both Hardhat and Anvil exporting
ETH_RPCas:In follow up pull requests we want to: