-
Notifications
You must be signed in to change notification settings - Fork 134
Quarter hour price update #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described in my system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me too! Thanks for fast programming! 👍
nelgi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked these modification on 2 different systems and they seem to work without errors.
|
Works for me as well, great work - thanks! 🥇 |
|
Works 👍 |
|
Does this take into account situations, where the price does not change every 15 minutes? |
The only nordpool market NOT on 15-minute MTU in DayAhead is ireland, which is on 30 minutes. In that case, every other update will just return the same price, since the sensor updates every 15 minutes |
Fair enough. I was just fancying myself of an implementation that would work on any intervals if they are for some reason ever to be changed again in the future. I had also some time ago problems with the nordpool sensor updating more often than the actual price updates and made a request to make state changes more robust and predictable: #379 |
|
added the changes manually to my files and it works, it now updates the prices to reflect the 15 min interval on the sensor (sorry i know i should probably help out in a more proper way but have not learned how yet) still since I did some manual tests I thought it would not hurt to add the comment |
|
See comments in #496 |
|
@Hellowlol please merge this asap |
|
we need a 0.0.18 |
|
There are still symbols and comments referring to hourly prices that needs to be fixed. Here: Do a |
Symbols don't matter, what matters is the logic. it could be just comment lines, not actual code. |
Comments and symbols must match actual code for readable and maintainable code. Basic rule. |
What I'm saying is that did you just run grep and post the results or did you also check each file and the occurrence of it? |
I did some of the work in this PR: #497 I agree that the changes should be done, but i believe in "make it work, then make it pretty", so while it's important to make maintainable code, first and foremost it should work, and right now it's not, which is why i closed the PR in favour of this one. I'm not going to finish my PR with the Readme-files and changes to the apex-chart, etc, so someone else feel free to fork my repository and continue |
|
This log entry also shows up from time to time, not sure what it means. Maybe a side effect of above size warning.?
|
|
Regarding the 16384Byte limit i just removed the endtimes in my code thus cutting bytewise size into almost half and now it all fits in "one" sensor "block", I'm a heavy addict of carcharger and diverse electric usage appliances and i've yet to find any Integrations that use the endtimes for anything. Could this perhaps solve something (I added a 23:45 endtime back into the code to "mark" the end of the day). Seems everyone has remained sane and not used the START and END time for blocks instead just extrapolating from when the next "expensive" time after it starts to mark the end of the previous one thus saving tons of redundant code ... |
|
I have actually started to use the end date. I use it for two purposes:
1. Determine the length of the slot, I built this so it automatically would
work then switching between 1h to 15min MTU. So I know how much charge I
will get and so forth.
2. Determine which points are next to each other after certain slots have
been filtered out.
…On Mon, 13 Oct 2025, 02:21 friskens, ***@***.***> wrote:
*friskens* left a comment (custom-components/nordpool#491)
<#491 (comment)>
Regarding the 16384Byte limit i just removed the endtimes in my code thus
cutting bytewise size into almost half and now it all fits in "one" sensor
"block", I'm a heavy addict of carcharger and diverse electric usage
appliances and i've yet to find any Integrations that use the endtimes for
anything. Could this perhaps solve something (I added a 23:45 endtime back
into the code to "mark" the end of the day). Seems everyone has remained
sane and not used the START and END time for blocks instead just
extrapolating from when the next "expensive" time after it starts to mark
the end of the previous one thus saving tons of redundant code ...
—
Reply to this email directly, view it on GitHub
<#491 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKPWGTEVDQDC6PKB6UT4U33XLWBDAVCNFSM6AAAAACH6L5LD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOJVGUYDQOJRGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Same here. If you have time, just try my solution if it's possible for you. |
I have been running this PR since it was pushed. I see the error in logs and from what I understand of the log message it states "Attributes will not be stored". And that is just what you are proposing to do, so your solution sounds nice and easy. Not sure what happens if those attributes aren't stored. For example upon restart I guess the data will be missing and it would need to fetch the data again? |
I have been using |
|
Makes sense to not record those large lists. But will that solve issues with other integrations or automations having too small sensor buffers? (or maybe this is a non-issue?) |
Removing features after the fact should always be done with serious consideration. This integration has existed long enough that many other integrations and functionalities undoubtedly rely on these attributes. In this case, removing attributes doesn’t seem justified simply because someone doesn’t need them. Any removal or change will inevitably break other functionality for many users, making the integration unusable from their perspective or forcing significant rework to restore functionality by other means. We cannot assume that what isn’t important to me isn’t important to someone else. There are multiple ways to solve the 16-kilobyte limit, so removing attributes is not justified in an established, widely used integration. I suggest considering solutions more "kindly". In my view, the best fix is simply to keep the list-type attributes out of the recorder. That way nobody loses the attributes they rely on. I also struggle to see why these lists should be stored or what value it adds... unless we’re talking about something like Holt-Winters style forecasting with seasonality for data analytics, and even then there are probably better places to do that than a Home Assistant and integration. :) |
|
I don't understand why issue with 16k bytes is brought to this PR, can @Hellowlol just merge this PR asap and then we can figure issue with 16k in another PR? I think this PR is more important than 16k issue which has no harm in it. |
|
LGTM! |
|
So what's blocking this? |
|
The problem with 16k attribute exists already now, with or without this PR right? The data is already there. So it shouldn't stop this PR but be threated as a separate problem. |
Nothing and it's getting ridiculous how long we're not approving this PR. I can't call this anything but incompetence |
Please, that is a really unnecessary comment. This is a nice person that has spent a lot of creating something for other people to enjoy. I understand your frustration but this person probably just have a life that came in between, so please refrain from those kind of comments. Edit: typo |
I'm sure they're nice person, but for some reason all are obsessed over a warning message that isn't related to the problem of this PR. They've had multiple opportunities to merge but didn't do so. And it's okay to have a life, but if it leaves no time to maintain the repo with high quality, I'd suggest adding another maintainer that can actively maintain this repo. |
|
I want to also say that I feel criticizing the maintainer is not going to increase their motivation of spending their free time for our benefit. What we can do here, is to come up with a workaround while this gets sorted out. Can anyone recommend a good way for me to run this fork in a way that doesn't require me to change every entity ID I have? I have installed the extension via HACS. My current plan is to simply overwrite the files in HACS's component directory with these ones and restart HA. If I'm right the IDs should remain the same, no? When the component is eventually updated, it should overwrite my changes and I live happily ever after. That's the theory anyway. If no one offers a better solution I will try this and report my findings so others can at least avoid whatever mistakes I end up making. |
Nobody is criticising the author, but if he has little to no time to maintain the repo, I think it's beneficial for everybody to add new maintainers to keep the repo alive. You don't seem to get the point what I mean. I'm not here to throw rocks at anybody, I want you guys to face the reality, nothing has been moving for a month now. You may not like or want to accept the truth, but it is the truth. @Hellowlol do you agree? What do we do next? |
Yes, that is exactly what I did on day one. I download the code for this PR and then simply dumped the code overwriting what hacs had downloaded. It's been working great since then. 🙂 |
|
I promised to report back. Works like a charm. I downloaded the zip from the package, extracted it to a separate dir and copied the relevant subdirectory over the current installation. Have been running it like this for a few days, everything looks fine. From what I can see this can be merged. |
I just added https://github.com/Teme-V/nordpool.git to HACS as custom repository, obviously first you need remove this one. |
|
Great stuff @Hellowlol nice to see you got some spare time this christmas! Thank you! |
+1 we do need someone to maintain the repo to keep it healthy |
|
yeah fire Hellowlol, for doing crappy job. Close repo if don't wanna maintain it. Simple as that. 15min nordpool data fix was added here in october, and only now you able to release it so people using HACS can finally upgrade. Add people to repo so they could do that instead of you if you have no time or no longer want to do this. |
|
Locking the comments because the discussion is no longer productive. Right now, it’s honestly tempting to archive or delete the repo. If anyone is genuinely interested in helping out, I’d really appreciate the support. |



Update sensor price every quarter hour