Skip to content

Correct time calculations #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Correct time calculations #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/Segment/Utilities/QueueTimer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,18 +73,18 @@ internal class QueueTimer {

extension TimeInterval {
static func milliseconds(_ value: Int) -> TimeInterval {
return TimeInterval(value / 1000)
return TimeInterval(value) / 1000
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This calculation had an integer-division problem. My change makes it so that we're dividing Double types rather than Int types, and therefore are no longer truncating.

}

static func seconds(_ value: Int) -> TimeInterval {
return TimeInterval(value)
}

static func hours(_ value: Int) -> TimeInterval {
return TimeInterval(60 * value)
return TimeInterval(60 * 60 * value)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a TimeInterval represents a second. There are 60 seconds in a minute, and 60 seconds in an hour.

}

static func days(_ value: Int) -> TimeInterval {
return TimeInterval((60 * value) * 24)
return TimeInterval((60 * 60 * value) * 24)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

}
}