Skip to content

chore: fix slack dependency changes in workflows #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shahroz16 merged 2 commits into from
Feb 18, 2025
Merged

chore: fix slack dependency changes in workflows #495

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b679a61
testing
Shahroz16 Feb 18, 2025
29f1313
commented out the broken workflow
Shahroz16 Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions .github/workflows/deploy-sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,16 @@ jobs:
- name: Setup Android SDK
uses: ./.github/actions/setup-android

# Generate SDK size report to update in main branch before deploying new release.
# The report is pushed by semantic-release action below by including files listed in the
# `assets` array in the `.releaserc` file.
- name: Generate SDK Size Report
run: |
./gradlew publishToMavenLocal
./gradlew generateSdkSizeReport -PwriteReportTo=reports/sdk-binary-size.json
env:
# Use local version to make sure the report is generated for the current changes
IS_DEVELOPMENT: 'true'
# # Generate SDK size report to update in main branch before deploying new release.
# # The report is pushed by semantic-release action below by including files listed in the
# # `assets` array in the `.releaserc` file.
# - name: Generate SDK Size Report
# run: |
# ./gradlew publishToMavenLocal
# ./gradlew generateSdkSizeReport -PwriteReportTo=reports/sdk-binary-size.json
# env:
# # Use local version to make sure the report is generated for the current changes
# IS_DEVELOPMENT: 'true'
Comment on lines +31 to +40
Copy link
Contributor Author

@Shahroz16 Shahroz16 Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is breaking the deployment for now


# Semantic-release tool is used to:
# 1. Determine the next semantic version for the software during deployment.
Expand Down Expand Up @@ -65,6 +65,8 @@ jobs:
uses: slackapi/slack-github-action@v2.0.0
if: steps.semantic-release.outputs.new_release_published == 'true' # only run if a git tag was made.
with:
webhook: ${{ secrets.SLACK_NOTIFY_RELEASES_WEBHOOK_URL }}
webhook-type: incoming-webhook
# Use block kit for format of the JSON payloads: https://app.slack.com/block-kit-builder
payload: |
{
Expand Down Expand Up @@ -110,6 +112,8 @@ jobs:
uses: slackapi/slack-github-action@v2.0.0
if: ${{ failure() }} # only run this if any previous step failed
with:
webhook: ${{ secrets.SLACK_NOTIFY_RELEASES_WEBHOOK_URL }}
webhook-type: incoming-webhook
# Use block kit for format of the JSON payloads: https://app.slack.com/block-kit-builder
payload: |
{
Expand Down Expand Up @@ -168,6 +172,8 @@ jobs:
uses: slackapi/slack-github-action@v2.0.0
if: ${{ success() }}
with:
webhook: ${{ secrets.SLACK_NOTIFY_RELEASES_WEBHOOK_URL }}
webhook-type: incoming-webhook
# Use block kit for format of the JSON payloads: https://app.slack.com/block-kit-builder
payload: |
{
Expand Down Expand Up @@ -205,6 +211,8 @@ jobs:
uses: slackapi/slack-github-action@v2.0.0
if: ${{ failure() }} # only run this if any previous step failed
with:
webhook: ${{ secrets.SLACK_NOTIFY_RELEASES_WEBHOOK_URL }}
webhook-type: incoming-webhook
# Use block kit for format of the JSON payloads: https://app.slack.com/block-kit-builder
payload: |
{
Expand Down
Loading