chore: integrate location module into sample apps#658
Merged
Shahroz16 merged 1 commit intofeat/real-time-locationfrom Feb 18, 2026
Merged
chore: integrate location module into sample apps#658Shahroz16 merged 1 commit intofeat/real-time-locationfrom
Shahroz16 merged 1 commit intofeat/real-time-locationfrom
Conversation
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/real-time-location #658 +/- ##
==========================================================
Coverage ? 68.19%
Complexity ? 760
==========================================================
Files ? 142
Lines ? 4323
Branches ? 582
==========================================================
Hits ? 2948
Misses ? 1149
Partials ? 226 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
Build available to test |
|
📏 SDK Binary Size Comparison ReportNo changes detected in SDK binary size ✅ |
Shahroz16
force-pushed
the
feat/location-one-shot
branch
from
2a698db to
c710f0e
Compare
Shahroz16
force-pushed
the
feat/location-sample-app
branch
from
25d3082 to
5503e87
Compare
|
|
Shahroz16
force-pushed
the
feat/location-one-shot
branch
from
c710f0e to
03eb67c
Compare
Shahroz16
force-pushed
the
feat/location-sample-app
branch
from
5503e87 to
40ea244
Compare
|
|
Shahroz16
force-pushed
the
feat/location-one-shot
branch
from
03eb67c to
c690302
Compare
Shahroz16
force-pushed
the
feat/location-sample-app
branch
from
40ea244 to
f26fe5f
Compare
|
|
Shahroz16
force-pushed
the
feat/location-one-shot
branch
from
c690302 to
060c288
Compare
Shahroz16
force-pushed
the
feat/location-sample-app
branch
from
f26fe5f to
a6e2a88
Compare
|
|
Shahroz16
force-pushed
the
feat/location-one-shot
branch
from
060c288 to
fe5c170
Compare
Shahroz16
force-pushed
the
feat/location-sample-app
branch
from
a6e2a88 to
9019907
Compare
|
|
Shahroz16
force-pushed
the
feat/location-one-shot
branch
from
fe5c170 to
3a4bb53
Compare
Shahroz16
force-pushed
the
feat/location-sample-app
branch
from
9019907 to
c405a99
Compare
Shahroz16
force-pushed
the
feat/location-sample-app
branch
from
5a046b9 to
c03531e
Compare
Shahroz16
force-pushed
the
feat/location-one-shot
branch
from
5590940 to
6772e13
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...out/src/main/java/io/customer/android/sample/java_layout/ui/dashboard/DashboardActivity.java
Show resolved
Hide resolved
| ) | ||
| ) | ||
| .addCustomerIOModule(ModuleMessagingPushFCM()) | ||
| .addCustomerIOModule(ModuleLocation()) |
There was a problem hiding this comment.
Kotlin Compose sample missing location dashboard features
Medium Severity
ModuleLocation() is registered in the Kotlin Compose sample but no corresponding UI was added. The PR description explicitly mentions adding setManualLocation() and requestLocationOnce() to DashboardViewModel and adding location action buttons to the dashboard — but neither DashboardViewModel.kt nor Dashboard.kt was modified. The module is initialized with no way for users to interact with it.
Shahroz16
force-pushed
the
feat/location-one-shot
branch
from
6772e13 to
ce9255c
Compare
Shahroz16
force-pushed
the
feat/location-sample-app
branch
from
c03531e to
077856a
Compare
|
|
|
|
Shahroz16
force-pushed
the
feat/location-one-shot
branch
from
ce9255c to
e8f0aae
Compare
Shahroz16
force-pushed
the
feat/location-sample-app
branch
from
077856a to
bde23f5
Compare
|
|
Base automatically changed from
feat/location-one-shot
to
feat/real-time-location
February 18, 2026 14:58
|
|
Shahroz16
force-pushed
the
feat/location-sample-app
branch
from
bde23f5 to
918e317
Compare
|
|
Shahroz16
force-pushed
the
feat/location-sample-app
branch
from
918e317 to
7855636
Compare
Register ModuleLocation in both sample apps. Add location testing UI to the Java sample app: request location permission, set manual location, and request one-shot SDK-managed location. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Shahroz16
force-pushed
the
feat/location-sample-app
branch
from
7855636 to
55ea6ca
Compare
|
|
| ? LocationManager.GPS_PROVIDER | ||
| : LocationManager.NETWORK_PROVIDER; | ||
|
|
||
| locationManager.requestSingleUpdate(provider, locationListener, null); |
There was a problem hiding this comment.
GPS provider crashes when only coarse permission granted
Medium Severity
isLocationPermissionGranted() returns true when only ACCESS_COARSE_LOCATION is granted, but fetchDeviceLocation() may select GPS_PROVIDER which requires ACCESS_FINE_LOCATION. On Android 12+, users can choose "Approximate" location, granting only coarse permission. In that scenario, requestSingleUpdate with GPS_PROVIDER throws a SecurityException, crashing the app. The provider selection needs to account for which specific permission was actually granted.
Additional Locations (1)
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModuleLocation()in both Kotlin Compose and Java sample appsMainActivitysetManualLocation()andrequestLocationOnce()toDashboardViewModellocationmodule dependency to sample app gradle configNote
Medium Risk
Adds location permissions and runtime location flows in the sample app, which can affect privacy/permission behavior and introduce device-dependent edge cases, but is isolated to samples/testing UI.
Overview
Adds the Customer.io
locationmodule to the sample apps: includes a new:locationdependency, registersModuleLocation()during SDK initialization in both the Java Layout and Kotlin Compose samples, and requestsACCESS_FINE_LOCATIONin the Java sample manifest.Introduces a new Java
LocationTestActivity(linked from a new Dashboard button) with UI/resources to set preset/manual coordinates, fetch device location, and trigger/stop SDK location updates, including runtime permission handling and settings fallback dialogs.Written by Cursor Bugbot for commit 55ea6ca. This will update automatically on new commits. Configure here.