Draft
Conversation
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. |
|
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report vs. main branch |
| didFailToRegisterForRemoteNotificationsWithError error: Error | ||
| ) { | ||
| MessagingPushAPN.shared.application(application, didFailToRegisterForRemoteNotificationsWithError: error) | ||
| } |
Contributor
There was a problem hiding this comment.
I think maybe we can keep the names as they used to be to match AppDelegate callbacks:
- Make it less likely that people would be confused about their wiring
- It also future proofs our API in case we want it to do more than just registering/deleting token or smth else
| #selector(UIApplicationDelegate.application(_:didRegisterForRemoteNotificationsWithDeviceToken:)), | ||
| #selector(UIApplicationDelegate.application(_:didFailToRegisterForRemoteNotificationsWithError:)), | ||
| #selector(UIApplicationDelegate.application(_:continue:restorationHandler:)), | ||
| #selector(UIApplicationDelegate.application(_:open:options:)), |
Contributor
There was a problem hiding this comment.
I believe we used to intercept couple of more App Delegate callbacks, do we need counterparts for these as well?
| } | ||
|
|
||
| @available(iOSApplicationExtension, unavailable) | ||
| open class CioProviderAgnosticAppDelegate: CioAppDelegateType, UNUserNotificationCenterDelegate { |
Contributor
There was a problem hiding this comment.
I think we should deprecate this for the time being and have the two approaches live side by side. This gives customers more time to migrate since we have some time before app delegates go away
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete each step to get your pull request merged in. Learn more about the workflow this project uses.