fix: remove TaskBag to eliminate threading issue in EventBusHandler#931
Draft
fix: remove TaskBag to eliminate threading issue in EventBusHandler#931
Conversation
…tor. Old TaskBag implementation deleted. Tests are updated.
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. |
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report vs. main branch |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #931 +/- ##
==========================================
+ Coverage 62.84% 63.11% +0.27%
==========================================
Files 166 165 -1
Lines 7345 7337 -8
==========================================
+ Hits 4616 4631 +15
+ Misses 2729 2706 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The
taskBag += Task { ... }operation performed a non-atomic read-modify-write sequence on an@Atomicproperty. Even though the property was marked as atomic, the compound operation itself wasn't, leading to potential task loss when multiple threads appended tasks concurrently.Solution
After analysis, we determined that TaskBag was unnecessary complexity:
By removing TaskBag entirely, we:
Changes
Testing
test_initialization_givenEventBusHandler_expectEventsLoadedFromStorage