refactor!: Introduce Synchronized primitive and adapt classes to its use #974
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| import Foundation | ||
|
|
||
| extension OperationQueue { | ||
| func addAsyncOperation(asyncBlock: @escaping () async -> Void) { | ||
| addOperation(AsyncOperation(asyncBlock: asyncBlock)) | ||
| } | ||
| } | ||
|
|
||
| public final class AsyncOperation: Operation, @unchecked Sendable { | ||
| private let activeTask: Synchronized<Task<Void, Never>?> = .init(initial: nil) | ||
|
|
||
| public let asyncBlock: () async -> Void | ||
|
|
||
| public init(asyncBlock: @escaping () async -> Void) { | ||
| self.asyncBlock = asyncBlock | ||
| } | ||
|
|
||
| // Only required when you want to manually start an operation | ||
| // Ignored when an operation is added to a queue. | ||
| override public var isAsynchronous: Bool { true } | ||
|
|
||
| // State is accessed and modified in a thread safe and KVO compliant way. | ||
| private let _isExecuting: Synchronized<Bool> = .init(initial: false) | ||
| override public private(set) var isExecuting: Bool { | ||
| get { | ||
| _isExecuting.wrappedValue | ||
| } | ||
| set { | ||
| willChangeValue(forKey: "isExecuting") | ||
| _isExecuting.wrappedValue = newValue | ||
| didChangeValue(forKey: "isExecuting") | ||
| } | ||
| } | ||
|
|
||
| private let _isFinished: Synchronized<Bool> = .init(initial: false) | ||
| override public private(set) var isFinished: Bool { | ||
| get { | ||
| _isFinished.wrappedValue | ||
| } | ||
| set { | ||
| willChangeValue(forKey: "isFinished") | ||
| _isFinished.wrappedValue = newValue | ||
| didChangeValue(forKey: "isFinished") | ||
| } | ||
| } | ||
|
|
||
| override public func start() { | ||
| guard !isCancelled else { | ||
| finish() | ||
| return | ||
| } | ||
| isFinished = false | ||
| isExecuting = true | ||
| main() | ||
| } | ||
|
|
||
| override public func main() { | ||
| activeTask.wrappedValue = Task { [weak self] in | ||
| guard let self, !isCancelled else { return } | ||
| await asyncBlock() | ||
| finish() | ||
| } | ||
| } | ||
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. AsyncOperation cancellation leaves operation in incomplete stateWhen |
||
|
|
||
| override public func cancel() { | ||
| activeTask.mutating { value in | ||
| value?.cancel() | ||
| value = nil | ||
| } | ||
| super.cancel() | ||
| } | ||
|
|
||
| func finish() { | ||
| isExecuting = false | ||
| isFinished = true | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.