chore: remove old architecture support in iOS implementation #548
+51
−416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
This was referenced Dec 1, 2025
mahmoud-elmorabea
approved these changes
Dec 22, 2025
| func setDeviceAttributes(_ attributes: [String: Any]) { | ||
| guard ensureInitialized() else { return } | ||
| CustomerIO.shared.deviceAttributes = attributes | ||
| CustomerIO.shared.setDeviceAttributes(attributes) |
Base automatically changed from
mbl-1476-ts-cleanup
to
feature/react-native-0-83
December 22, 2025 20:23
mrehan27
force-pushed
the
mbl-1477-ios-cleanup
branch
from
cfb7a1d to
04bb189
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This reverts commit 95e637c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of: MBL-1477
Summary
This PR removes all old React Native architecture (pre TurboModules) support from iOS side of React Native SDK, simplifying the codebase by consolidating everything into single implementations that assume the New Architecture (TurboModules + Fabric) compatible setup. This cleanup eliminates dual path complexity, reduces maintenance overhead moving forward., and aligns with the Android cleanup done in the previous PR.
Changes
NativeCustomerIOLoggingImplementationandNativeMessagingInAppImplementation, moving their logic directly intoNativeCustomerIOLoggingandNativeMessagingInAppNativeCustomerIOLoggingLegacy,NativeMessagingInAppLegacy#ifdef RCT_NEW_ARCH_ENABLEDchecks from*.mmfiles*.mmfiles to use only New Architecture / Fabric APIsRCTInlineMessageNativeViewManager.m (old arch version)#ifdef __cplusplusguard inRCTInlineMessageNative.hto prevent C++ import errors in Objective-C only contexts (e.g., CocoaPods umbrella headers)profileAttributes=>setProfileAttributes()deviceAttributes=>setDeviceAttributes()example/ios/PodfilePR Stack:
Note
Consolidates iOS wrappers to New Architecture only (TurboModules + Fabric).
#ifdef RCT_NEW_ARCH_ENABLEDbranches across*.mm; deleteRCTInlineMessageNativeViewManager.mNativeCustomerIOLoggingandNativeMessagingInAppnow contain their own initialization/event wiring#ifdef __cplusplusguard inRCTInlineMessageNative.h; makeRCTInlineMessageNativeconform toRCTInlineMessageNativeViewProtocolsetProfileAttributes(...)andsetDeviceAttributes(...)replace deprecated propertiesexample/ios/PodfilecommentsWritten by Cursor Bugbot for commit df95a43. This will update automatically on new commits. Configure here.