fix previewing with initial invalid selector#130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Live Preview session is triggered by "Or select target" and the initial selector is empty or invalid, the Preview Bar fails to load.
Note
Medium Risk
Changes message rendering decisions during preview sessions (fallbacking to overlay and skipping tooltip errors) and adds new picker-state checks, which could affect how/when messages display in edge cases.
Overview
Fixes Live Preview sessions that start with an empty/invalid target selector by ensuring the message iframe can still mount and the preview bar can activate the element picker.
In
message-manager, missing inline targets in preview now fallback to overlay rendering, and tooltip target validation/errors are relaxed in preview (including skipping tooltip reset/errors so the picker can take over). Rendering onrouteLoadednow checksisPreviewPickerActive()to avoid showing the fallback message behind the picker.In
preview-bar-manager,isReadyToApplynow treats$element_idas an invalid placeholder, tooltip/inline share the same selector controls, and the bar will auto-activate the picker whenever settings aren’t ready (including during initial step/type overrides).Written by Cursor Bugbot for commit feb8077. This will update automatically on new commits. Configure here.