Fallback to modal if elementId is not found during live preview#131
Merged
BernardGatt merged 1 commit intodevelopfrom Mar 26, 2026
Merged
Fallback to modal if elementId is not found during live preview#131BernardGatt merged 1 commit intodevelopfrom
BernardGatt merged 1 commit intodevelopfrom
Conversation
…dal and show an indicator around the elementId text field.
karngyan
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During live preview, if an elementId is not found we fallback to a modal and show an indicator around the elementId text field.
Addresses: INAPP-14308
Note
Medium Risk
Changes message rendering behavior during preview sessions by conditionally switching from embedded to overlay display; risk is moderate because it affects how in-app messages are presented and could alter preview vs. production parity if the gating is wrong.
Overview
Improves live preview resilience when an embedded message’s
elementIdis invalid or missing.handleMessagenow detects live preview embedded messages and, if the target element can’t be found viafindElement, falls back toshowMessage(overlay/modal) so the message still renders and placement can be adjusted; otherwise it continues embedding as before. The preview bar also validates the element selector field and visually marks it invalid via a newgist-pb-input--invalidstyle, and tests were added/updated to cover the new preview fallback behavior.Written by Cursor Bugbot for commit 8355d91. This will update automatically on new commits. Configure here.