Uvicorn: use --uds instead of --fd 0 to enable multi-worker support#10481
Open
Uvicorn: use --uds instead of --fd 0 to enable multi-worker support#10481
Conversation
Supervisord socket delegation via `--fd` is incompatible with Uvicorn's `--workers` argument (forces TCP fallback). Moved socket creation to Uvicorn internal manager via `--uds` to allow multiple workers.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
SpecLad
reviewed
Apr 17, 2026
| EVENTS_LOCAL_DB_FILE = Path( | ||
| EVENTS_LOCAL_DB_ROOT, | ||
| os.getenv("CVAT_EVENTS_LOCAL_DB_FILENAME", "events.db"), | ||
| f"events_{os.getpid()}.db", |
Contributor
There was a problem hiding this comment.
Won't this result in a loss of buffered events if the server gets killed and restarted?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supervisord socket delegation via
--fdis incompatible with Uvicorn's--workersargument (forces TCP fallback). Moved socket creation to Uvicorn internal manager via--udsto allow multiple workers.Motivation and context
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.