[AI Gen] Fixed typescript errors and enabled linter for cvat-core#10489
[AI Gen] Fixed typescript errors and enabled linter for cvat-core#10489
Conversation
bsekachev
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccbfb2e408
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private syncAggregateState(): void { | ||
| this.occluded = this.elements.every((element) => element.occluded); | ||
| this.lock = this.elements.every((element) => element.lock); |
There was a problem hiding this comment.
SkeletonShape now caches aggregate state in this.lock/this.occluded, but the undo/redo callbacks created in updateElements only mutate child element fields and never resync that cache. After undoing or redoing a skeleton lock change, this.elements[*].lock can differ from cached this.lock, and methods that rely on this.lock (like delete() and the early return in save()) can incorrectly treat an unlocked skeleton as locked (or vice versa).
Useful? React with 👍 / 👎.
1 participant
Motivation and context
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.