Bugfix for the migration to pycolmap.Database. #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B1ueber2y
changed the title
Member
Author
|
Did some tests myself to make sure everything runs. Sorry for not checking thoroughly on Monday. |
sarlinpe
approved these changes
Sep 24, 2025
|
It looks like, with the latest COLMAP changes, the pycolmap API has shifted again and HLoc reconstruction still breaks due to Database()/num_images mismatch ? |
Member
Author
Thanks a lot for reporting. Should be fixed here: #483. Let us know if you meet other issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for #478.
db.read_all_images()is a list rather than a map.