Properly handle project names with dashes#2
Open
dluksza wants to merge 1 commit intocvillecsteele:masterfrom
Open
Properly handle project names with dashes#2dluksza wants to merge 1 commit intocvillecsteele:masterfrom
dluksza wants to merge 1 commit intocvillecsteele:masterfrom
Conversation
johannesloetzsch
pushed a commit
to johannesloetzsch/lein-git-version
that referenced
this pull request
Aug 31, 2019
Fix writing version file keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currenlty lein-git-version plugin will not properly work with projects that have dash in its name. It will generate version.clj file in wrong directory, eg. when project name is 'my-proj' then plugin will generate version.clj file in src/my-proj/version.clj, causing compilation failure. In this case file should be generated in src/my_proj/.