WIP: Implement method to resolve imports#559
Open
cvogt wants to merge 2 commits intocvogt:masterfrom
Baccata:handle-import-scope
Open
WIP: Implement method to resolve imports#559cvogt wants to merge 2 commits intocvogt:masterfrom Baccata:handle-import-scope
cvogt wants to merge 2 commits intocvogt:masterfrom
Baccata:handle-import-scope
Conversation
In order to resolve imports, one need to : - resolve the properties of the xml declaration of the import. This means that the parents have to be resolved first. - resolve the properties of the dependencies contained by the import. This means that when looking up values in the xml, you potentially have to resolve the transitive poms of the import first. This therefore parameterise the "lookup" and "properties" method in order to take the scope into consideration. Typically the argument will be "transitivePom" or "transitivePom and transitiveImports" Also changes the order of how the transitivePom and imports are mixed together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
creating a PR for easier comparison